[Ironruby-core] Code Review: CC2

Tomas Matousek Tomas.Matousek at microsoft.com
Fri Jun 6 23:29:52 EDT 2008


tfpt review "/shelveset:CC2;REDMOND\tomat"

Replaces most uses of Ast.CodeContext() calls by references to the current RubyScope variable.
Removes uses of LambdaBuilder and scope factories.
Introduces LocalsBuilder - a simple List<VariableExpression> wrapper.

Moves a scope variable stored on FrameScope up to the VariableScope (renamed from SelfScope). The VariableScope represents a scope of local variables - it could either be a method scope, block scope, or module scope.

Merges RubyOps.Create*Scope and RubyOps.Initialize*Scope. This is now possible due to Ast.AllLocalVariables node. Factories are now explicitly called by IronRuby and not passed to DLR scopes.

Also fixes bug in module scopes - local variables were not allocated on a correct scope.

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CC2.diff
Type: application/octet-stream
Size: 150348 bytes
Desc: CC2.diff
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080606/b34ef4f4/attachment-0001.obj>


More information about the Ironruby-core mailing list