[Ironruby-core] Code Review: RubyPrecompilation

Dino Viehland dinov at exchange.microsoft.com
Fri Jun 6 13:31:21 EDT 2008

The only concerning thing I see in the Ruby changes are the Assembly.LoadFrom - what's up with that?  It's probably file for this simple case (because all of the dependencies will already be loaded) but it's a little scary.

Adding DLR Code Reviews just to make sure the DLR devs don't miss this.

-----Original Message-----
From: Tomas Matousek
Sent: Friday, June 06, 2008 10:11 AM
To: IronRuby External Code Reviewers; Rowan Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: RubyPrecompilation

Ruby and DLR.

tfpt review "/shelveset:RubyPrecompilation;REDMOND\tomat"

Removes dependency of precompiled code on optimized scopes.
Enables loading/saving precompiled assemblies in Ruby loader.
Implements IExpressionSerializable on ProtocolConversionAction to enable its serialization to IL.


More information about the Ironruby-core mailing list