[Ironruby-core] Code Review: unni1

Unnikrishnan Nair ksunair at yahoo.com
Wed Jul 16 22:51:49 EDT 2008


Jim,
 
As per your comments, I have modified the code and ran against Matz Ruby and verified the results. Yes you are correct 'nul' is same as 'NUL' as well. I have updated the patch as well.
 
Just curious, how come there is no representation of IronRuby in Lonestar Ruby conference?
 
Thanks.
Unni

--- On Wed, 7/16/08, Unnikrishnan Nair <ksunair at yahoo.com> wrote:

From: Unnikrishnan Nair <ksunair at yahoo.com>
Subject: Re: [Ironruby-core] Code Review: unni1
To: ironruby-core at rubyforge.org
Date: Wednesday, July 16, 2008, 10:34 AM







yes, I will do that.
Thanks.
Unni

--- On Tue, 7/15/08, Jim Deville <jdeville at microsoft.com> wrote:

From: Jim Deville <jdeville at microsoft.com>
Subject: Re: [Ironruby-core] Code Review: unni1
To: "ironruby-core at rubyforge.org" <ironruby-core at rubyforge.org>, "IronRuby External Code Reviewers" <irbrev at microsoft.com>
Date: Tuesday, July 15, 2008, 3:51 PM

While testing this manually I discovered that CRuby treats nul and NUL as zero
length files, while this patch only works for NUL. Unni, can you fix that and
resubmit?

Thanks,


JD


> -----Original Message-----
> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> bounces at rubyforge.org] On Behalf Of Jim Deville
> Sent: Tuesday, July 15, 2008 2:31 PM
> To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers
> Subject: Re: [Ironruby-core] Code Review: unni1
>
> Reviewed F2F with John
>
>
> JD
>
> > -----Original Message-----
> > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> > bounces at rubyforge.org] On Behalf Of Jim Deville
> > Sent: Tuesday, July 15, 2008 1:45 PM
> > To: IronRuby External Code Reviewers
> > Cc: ironruby-core at rubyforge.org
> > Subject: [Ironruby-core] Code Review: unni1
> >
> > tfpt review "/shelveset:unni1;REDMOND\jdeville"
> > Comment  :
> >   Patch from Unnikrishnan Nair to properly handle File.zero? for
> 'NUL'
> >
>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core

_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080716/b7d5b728/attachment.html>


More information about the Ironruby-core mailing list