[Ironruby-core] Code Review: unni1

Jim Deville jdeville at microsoft.com
Tue Jul 15 17:51:23 EDT 2008


While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit?

Thanks,


JD


> -----Original Message-----
> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> bounces at rubyforge.org] On Behalf Of Jim Deville
> Sent: Tuesday, July 15, 2008 2:31 PM
> To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers
> Subject: Re: [Ironruby-core] Code Review: unni1
>
> Reviewed F2F with John
>
>
> JD
>
> > -----Original Message-----
> > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> > bounces at rubyforge.org] On Behalf Of Jim Deville
> > Sent: Tuesday, July 15, 2008 1:45 PM
> > To: IronRuby External Code Reviewers
> > Cc: ironruby-core at rubyforge.org
> > Subject: [Ironruby-core] Code Review: unni1
> >
> > tfpt review "/shelveset:unni1;REDMOND\jdeville"
> > Comment  :
> >   Patch from Unnikrishnan Nair to properly handle File.zero? for
> 'NUL'
> >
>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core



More information about the Ironruby-core mailing list