[Ironruby-core] spec changes

Unnikrishnan Nair ksunair at yahoo.com
Mon Jul 7 10:17:50 EDT 2008


Thanks Jim, I have a test program that I run in windows with all the spec against ruby and against IR. It then compare the results and there is where I found this problem. yes, you are correct with your change. I think we can go with the change suggested.
By the way, did anyone compiled Ironruby on Mono? I finally got the mono installed and would like to try to compile it to run the spec on Mac this week. Do you guys consider Mac as *nix environment?
Thanks,
Unni

--- On Mon, 7/7/08, Jim Deville <jdeville at microsoft.com> wrote:

From: Jim Deville <jdeville at microsoft.com>
Subject: RE: [Ironruby-core] spec changes
To: "ksunair at yahoo.com" <ksunair at yahoo.com>, "ironruby-core at rubyforge.org" <ironruby-core at rubyforge.org>
Date: Monday, July 7, 2008, 1:32 AM








Well, it’s not as simple as that. The spec as written is for *nix paths, where ///// is root. So on one side we should move towards ///// returning the current drive. On the other hand, the notation // represents a UNC file path, which theoretically should resolve to a form of //server/share. I don’t know what CRuby wants dirname to return, and I also don’t know if we are going to deviate at all. I know that it currently returns //, but if you search for this function, there is some discussion about how it should behave, and I’m not sure how it resolved. For now, I’d suggest turning it into:
 
                platform_is_not :windows do
                                File.dirname(‘/////’).should == ‘/’
                end
                platform_is :windows do
                                File.dirname(‘/////’).should == ‘//’
                end
 
That will keep it working on *nix.
 
JD
 

From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Unnikrishnan Nair
Sent: Sunday, July 06, 2008 8:51 PM
To: ironruby-core at rubyforge.org
Subject: [Ironruby-core] spec changes
 




I think the following spec is wrong for FileOps.dirname
 
It is
 
    File.dirname('/////').should == '/'
 
but it should be 
 
    File.dirname('/////').should == '//'
 
If it is my misunderstanding, please let me know. 
 
Thanks,
Unni
 
 
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080707/1231dc74/attachment-0001.html>


More information about the Ironruby-core mailing list