[Ironruby-core] spec question
ksunair at yahoo.com
Sun Jul 6 02:07:19 EDT 2008
Now that we moved to GIT, do we submit the patches through GIT?
--- On Sat, 7/5/08, Jim Deville <jdeville at microsoft.com> wrote:
From: Jim Deville <jdeville at microsoft.com>
Subject: RE: [Ironruby-core] spec question
To: "ksunair at yahoo.com" <ksunair at yahoo.com>, "ironruby-core at rubyforge.org" <ironruby-core at rubyforge.org>
Date: Saturday, July 5, 2008, 2:16 PM
You should be fine making a patch. As for the test, it shouldn't run that test on Windows, but I'm not sure how the old runner works.
From: "Unnikrishnan Nair" <ksunair at yahoo.com>
To: "ironruby-core at rubyforge.org" <ironruby-core at rubyforge.org>
Sent: 7/5/08 1:22 AM
Subject: [Ironruby-core] spec question
When I was testing the File.zero? I noticed File.zero?('NUL') failed. I looked the code and it seems there is no special check there to exclude NUL as a not a valid file. I created a constant
private readonly static string NUL_VALUE = "NUL";
and added a else clause in the trycreate method as
else if (path.Equals(NUL_VALUE))
result = null;
and now the NUL works fine for zero.
I have two questions with this regard;
1. Can I apply these changes and push in the patch?
2. When we run the rake spec, will it include following tests on Windows?
platform :not, :mswin do
it "returns true for /dev/null" do
File.zero?('/dev/null').should == true
It seems it does, I haven't looked at the Rubinius to see how the platform is supposed to work.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Ironruby-core