[Ironruby-core] Code Review: StringGsubWithPattern

Dave Remy dremy at microsoft.com
Tue Jul 1 20:57:50 EDT 2008


tfpt review "/shelveset:StringGsubWithPattern;REDMOND\dremy"
Comment  :
  Changes for string.gsub with pattern ruby specs to pass.  The following tests now pass:

  String#gsub with pattern, replacement replaces \& and \0 with the complete match
  String#gsub with pattern, replacement replaces \` with everything before the current match
  String#gsub with pattern, replacement replaces \' with everything after the current match
  String#gsub with pattern, replacement replaces \+ with the last paren that actually matched
  String#gsub with pattern, replacement treats \+ as an empty string if there was no captures
  String#gsub with pattern, replacement maps \\ in replacement to \
  String#gsub with pattern, replacement leaves \ at the end of replacement untouched


-------------- next part --------------
A non-text attachment was scrubbed...
Name: StringGsubWithPattern.diff
Type: application/octet-stream
Size: 7932 bytes
Desc: StringGsubWithPattern.diff
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080701/0e5c5953/attachment.obj>


More information about the Ironruby-core mailing list