[Ironruby-core] Code Review: Simple ruby fixes

Tomas Matousek Tomas.Matousek at microsoft.com
Mon Dec 8 20:07:10 EST 2008

Looks good.


-----Original Message-----
From: Jim Deville
Sent: Monday, December 08, 2008 4:59 PM
To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers
Subject: RE: Code Review: Simple ruby fixes

Can you update Alias.ps1 as well? Otherwise looks good.


-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Shri Borde
Sent: Monday, December 08, 2008 4:42 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: [Ironruby-core] Code Review: Simple ruby fixes

  tfpt review "/shelveset:rt;REDMOND\sborde"

  Comment  :
  Simple fixes to the simple_test.rb runner as I was trying to get a feel for all the moving parts in Ruby testing. "finished" was not setting the exitcode, and so we were ignoring some failures, I disabled some of the tests, and fixed the trivial ones.
  Changed the Ruby method binder to throw AmbiguousMatchException for ambiguous method overloads, as throwing the ArgumentException was misleading.
  Added an alias for building just Microsoft.Scripting.dll

More information about the Ironruby-core mailing list