[Ironruby-core] Code Review: gets-1

John Lam (IRONRUBY) jflam at microsoft.com
Wed Aug 20 14:30:20 EDT 2008


tfpt review "/shelveset:gets-1;REDMOND\jflam"

Comment  :
- Fixes rubyforge bug #21342 - "gets" broken
- Adds code to test for closed streams
- Adds tainting to input returned from gets
- Adjusts input line correctly in # RubyExecutionContext
- Fixes getc to return a fixnum as opposed to a .NET char
- Fixes thunk from Kernel#gets to IO#gets



-------------- next part --------------
A non-text attachment was scrubbed...
Name: gets-1.diff
Type: application/octet-stream
Size: 19285 bytes
Desc: gets-1.diff
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080820/c79e9f03/attachment-0001.obj>


More information about the Ironruby-core mailing list