[Ironruby-core] Code Review: bugs-1

Tomas Matousek Tomas.Matousek at microsoft.com
Mon Aug 18 14:35:56 EDT 2008


Looks good.

-----Original Message-----
From: John Lam (IRONRUBY)
Sent: Monday, August 18, 2008 10:55 AM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: bugs-1

tfpt review "/shelveset:bugs-1;REDMOND\jflam"
Comment  :
  Fixes Rakefile to correctly generate case-sensitive filenames during compilation
  Fixes String#reverse and taint flow
  Fixes File#zero? behavior (works correctly for directory names, and handles NUL correctly)
  Stubs out implementation of File#symlink do throw a NotImplementedError (not sure if we can do this without P/Invoke)




More information about the Ironruby-core mailing list