[Ironruby-core] Code Review: unniseo

Curt Hagenlocher curth at microsoft.com
Fri Aug 8 12:27:49 EDT 2008

Change looks good.

-----Original Message-----
From: Jim Deville
Sent: Friday, August 08, 2008 1:21 AM
To: IronRuby External Code Reviewers; Curt Hagenlocher
Cc: ironruby-core at rubyforge.org
Subject: Code Review: unniseo

tfpt review "/shelveset:unniseo;REDMOND\jdeville"
Comment  :
  -Patch from Unni to return true for File.zero? 'nul' and File.zero? 'NUL'
  -Patch from Seo to search for both ruby and ruby.exe when searching for a ruby binary
  -Incorporates feedback from #ironruby IRC channel to use the first Ruby found instead of throwing an error when multiple are found

More information about the Ironruby-core mailing list