[Ironruby-core] Code Review: MO-RubyCall2
Curt Hagenlocher
curth at microsoft.com
Tue Aug 5 11:22:16 EDT 2008
There are two typos in IoOps.cs where _CreateIOSharedSite1 is being passed to the Target method of _CreateIOSharedSite11. It's a very hard-to-spot problem. Maybe one of the names should be changed. :)
There's also a typo in a comment in RubyModule -- should be ctor instead of ctro.
Otherwise, looks great.
-----Original Message-----
From: Tomas Matousek
Sent: Monday, August 04, 2008 8:07 PM
To: IronRuby External Code Reviewers; Rowan Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: MO-RubyCall2
tfpt review "/shelveset:MO-RubyCall2;REDMOND\tomat"
Switches all Ruby call actions to use meta-objects.
Also refactors some methods generating rules for procs and adds meta-objects for more Ruby classes (not used so far).
DLR: Makes ComMetaObject.IsComObject work in partial trust.
Tomas
More information about the Ironruby-core
mailing list