[Ironruby-core] FW: Can someone do a review of Pete's patch so that we can submit?

John Lam (DLR) jflam at microsoft.com
Thu Nov 29 17:13:29 EST 2007


Review from Tomas

From: Tomas Matousek
Sent: Thursday, November 29, 2007 12:32 PM
To: John Lam (DLR); IronRuby Team
Subject: RE: Can someone do a review of Pete's patch so that we can submit?

Few issues:


-          Fixnum.Abs is incorrect: abs(Int32.MinValue) will blow up, it should overlflow to BigInteger.

-          Why FloatOps.ToInteger doesn't just do try { return (int)self; } catch (...) {...} ? Flooring is actually incorrect: (-0.4).to_i gives 0 in Ruby while -1 in IronRuby. A test for this is apparently missing.

-          Why FloatOps.Divmod doesn't use Math.IEEEReminder? There might be some precision peculiarity involved.

Tomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/ironruby-core/attachments/20071129/4fb0de73/attachment.html 


More information about the Ironruby-core mailing list