[Ironruby-core] Patch submission - sockets

Sanghyeon Seo sanxiyn at gmail.com
Sat Dec 29 10:57:36 EST 2007

2007/12/29, Terence Lewis <lewistm at gmail.com>:
> This is my first contribution to an open source project, and I'm
> under no illusions as to the many flaws in this code. Any comments,
> criticism or suggestion is welcome, and I assume that the code will be
> reviewed before being accepted.

Hi, nice job.

1. Mixing tabs and spaces for indentation is a bad practice.
2. I don't think recvfrom is correct. It calls Socket.Receive, but it
should call Socket.ReceiveFrom.
3. IPAddress.Any reads better than IPAddress(0).
4. Not sure about DNS stuffs.

Seo Sanghyeon

More information about the Ironruby-core mailing list