From evan at protest.net  Tue Nov 13 19:39:04 2007
From: evan at protest.net (evan)
Date: Tue, 13 Nov 2007 16:39:04 -0800
Subject: [Georuby-devel] adding support for as_geojson
Message-ID: <86ec40c10711131639w65745a0anfa57fd4b0af7a2c1@mail.gmail.com>

Hi georuby folks,

So i've been using GeoRuby for a while. It's great for what it does.
One thing i noticed is there is support for as_georss on Geometry
objects but no as_geojson. I'd need geojson support so i'm going to be
writing up support for it. Just as a monkeypatch extension to GeoRuby
for the moment.

What's the process of submitting patches so my additions could be
rolled back in to GeoRuby. Use patch, include tests, etc... ?

thanks,
rabble

From evan at protest.net  Wed Nov 14 19:59:17 2007
From: evan at protest.net (evan)
Date: Wed, 14 Nov 2007 16:59:17 -0800
Subject: [Georuby-devel] adding support for as_geojson
In-Reply-To: <5EBCF367-BB53-4319-8BFF-AB8A9BF62358@i-sol.biz>
References: <86ec40c10711131639w65745a0anfa57fd4b0af7a2c1@mail.gmail.com>
	<5EBCF367-BB53-4319-8BFF-AB8A9BF62358@i-sol.biz>
Message-ID: <86ec40c10711141659id185ecev3c215984bc8b1037@mail.gmail.com>

Hey Linda,

Maybe i'm seeing a different code base or am on the wrong list!

I'm using GeoRuby 1.3.2, which i think is the latest release version.
I see some tests, all using Test::Unit.  I'm perfectly happy to write
rspec tests, but i don't see any in the code so far.

The  test coverage is decent, there's some bugs around proper WKB
encoding for complicated objects (anything beyond Point and LineString
really) and i know for a fact that there is no test coverage of WKB
creation for mysql as opposed to postgis. I'm not sure if the problem
is GeoRuby or MySQL, WKT works and i had to move on.

I'm happy to help provide examples, track down the bugs, do patches,
and the like. I just want to make sure i'm talking to folks about the
right project!

-rabble

On Nov 13, 2007 5:36 PM, Linda Derezinski <linda at i-sol.biz> wrote:
> Hi Rabble,
>
> We are using rspec tests if you are able to submit them or standard
> tests we will convert them into rspec.  We currently have 100% code
> coverage and plan to keep it that way.
>
> Please submit a patch with tests.
>
> Let us know if you run into any issues.
>
> Thanks
> -Linda
>
>
> On Nov 13, 2007, at 7:39 PM, evan wrote:
>
> > Hi georuby folks,
> >
> > So i've been using GeoRuby for a while. It's great for what it does.
> > One thing i noticed is there is support for as_georss on Geometry
> > objects but no as_geojson. I'd need geojson support so i'm going to be
> > writing up support for it. Just as a monkeypatch extension to GeoRuby
> > for the moment.
> >
> > What's the process of submitting patches so my additions could be
> > rolled back in to GeoRuby. Use patch, include tests, etc... ?
> >
> > thanks,
> > rabble
>
> > _______________________________________________
> > Georuby-devel mailing list
> > Georuby-devel at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/georuby-devel
>
>

From guilhem.vellut at gmail.com  Thu Nov 15 04:18:23 2007
From: guilhem.vellut at gmail.com (Guilhem Vellut)
Date: Thu, 15 Nov 2007 10:18:23 +0100
Subject: [Georuby-devel] adding support for as_geojson
In-Reply-To: <86ec40c10711141659id185ecev3c215984bc8b1037@mail.gmail.com>
References: <86ec40c10711131639w65745a0anfa57fd4b0af7a2c1@mail.gmail.com>
	<5EBCF367-BB53-4319-8BFF-AB8A9BF62358@i-sol.biz>
	<86ec40c10711141659id185ecev3c215984bc8b1037@mail.gmail.com>
Message-ID: <43f4b6ee0711150118h4c10dafape1523eb5d4bc0740@mail.gmail.com>

hello,
if you want to add as_json method, perfect. just send me the patch and
some runit tests or i can give you commit access to the repository
directly. just give me your rubyforge login for the latter option.
what issues do you have with the wkb? please submit bug reports. they
are (eventually) acted upon... the wkb reader/writer has tests for all
types of geometries and they seem to run ok. besides there are tests
for compatibility with the wkb reader/writer with both mysql and
postgis in the spatial adapter plugin although i haven't tested with
recent dbms versions.
guilhem

On Nov 15, 2007 1:59 AM, evan <evan at protest.net> wrote:
> Hey Linda,
>
> Maybe i'm seeing a different code base or am on the wrong list!
>
> I'm using GeoRuby 1.3.2, which i think is the latest release version.
> I see some tests, all using Test::Unit.  I'm perfectly happy to write
> rspec tests, but i don't see any in the code so far.
>
> The  test coverage is decent, there's some bugs around proper WKB
> encoding for complicated objects (anything beyond Point and LineString
> really) and i know for a fact that there is no test coverage of WKB
> creation for mysql as opposed to postgis. I'm not sure if the problem
> is GeoRuby or MySQL, WKT works and i had to move on.
>
> I'm happy to help provide examples, track down the bugs, do patches,
> and the like. I just want to make sure i'm talking to folks about the
> right project!
>
> -rabble
>
> On Nov 13, 2007 5:36 PM, Linda Derezinski <linda at i-sol.biz> wrote:
> > Hi Rabble,
> >
> > We are using rspec tests if you are able to submit them or standard
> > tests we will convert them into rspec.  We currently have 100% code
> > coverage and plan to keep it that way.
> >
> > Please submit a patch with tests.
> >
> > Let us know if you run into any issues.
> >
> > Thanks
> > -Linda
>
> >
> >
> > On Nov 13, 2007, at 7:39 PM, evan wrote:
> >
> > > Hi georuby folks,
> > >
> > > So i've been using GeoRuby for a while. It's great for what it does.
> > > One thing i noticed is there is support for as_georss on Geometry
> > > objects but no as_geojson. I'd need geojson support so i'm going to be
> > > writing up support for it. Just as a monkeypatch extension to GeoRuby
> > > for the moment.
> > >
> > > What's the process of submitting patches so my additions could be
> > > rolled back in to GeoRuby. Use patch, include tests, etc... ?
> > >
> > > thanks,
> > > rabble
> >
> > > _______________________________________________
> > > Georuby-devel mailing list
> > > Georuby-devel at rubyforge.org
> > > http://rubyforge.org/mailman/listinfo/georuby-devel
> >
> >
> _______________________________________________
> Georuby-devel mailing list
> Georuby-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/georuby-devel
>