[ditz-talk] What about labels?

[Nicolas Pouillard]

Excerpts from William Morgan's message of Wed Sep 03 05:23:55 +0200 2008:
> Reformatted excerpts from nicolas.pouillard's message of 2008-09-02:
> > Well, I've sent two merge requests. The first one is about to fix some
> > recent bugs in ditz found while testing labels, and an addition. The
> > second add the plugin for labels.
> 
> I've merged them in. Thanks, good stuff. (I actually just committed the
> same fix as your e008483d). A couple comments:
> 
> 1. What was the point of:
> -    @template_dir = File.dirname Ditz::find_ditz_file("share/ditz/index.rhtml")
> +    @template_dir = File.dirname Ditz::find_ditz_file("../share/ditz/index.rhtml")
> 
>    Was something not working? Can I change it back? The behavior should
>    be identical...
> 
> 2. The problem with storing the label objects in project.yaml is that if
>    two people both add a label, that file will conflict. So I think it
>    would be better to recreate the Label objects on the fly when the
>    project is loaded in.

OK, no problem about recreating the object, but I want declared labels to be
stored on disk.

>    
>    If you do that, you might not even need to serialize the Label object
>    itself. Components, releases, etc are just stored as strings in issue
>    objects, which makes the YAML easier to read and modify.
> 
>    (Components and releases are scheduled to move out of project.yaml
>    too---see issue 80c02356).

OK, once this issue (80c02356) is fixed, I will do the same for labels.

-- 
Nicolas Pouillard aka Ertai
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/ditz-talk/attachments/20080903/31d2b170/attachment.bin>