[ditz-talk] [PATCH] Allow ditz claim abcd oprah

William Morgan wmorgan-ditz at masanjin.net
Sun Nov 9 22:48:32 EST 2008


Reformatted excerpts from Thomas Nichols's message of 2008-11-07:
> Not sure whether these are better as email patches for discussion, or
> merge requests (from f3423e0 on thomasns-clone) on Gitorious?

I'm personally happy with either, although Gitorious merge requests
don't notify the list, so you have to do that manually. A merge request
might be nicer if it's a big feature that has several commits. But I'm
not that picky.

Unfortunately Thunderbird has helpfully text-wrapped your patch, so it's
corrupted. I recommend using git format-patch, which will turn commits
commits into emails, and allow me to easily apply them while preserving
your commit messages and giving you credit in the development history.

> WDYT? Is this a change that's useful to others?

I think this is a good change, but it needs a little more work before it
goes in. In particular I'd like to see:

- commands for managing aliases (adding and removing)
- the ability to use either an email address or an alias

The ability to assign issues to people is definitely desireable.

> BTW I'm a bit nervous of continuing with the current implementation of
> 'mine' since it depends AFAICT on a string comparison of the
> human-readable email address. Would it be better to store the nickname
> in the issue-*.yaml 'claimer:' field, instead of the expanded email
> address, so that emails can change without breaking the output of
> 'mine'?

Although it's not ideal in certain situations, I'd like to keep with the
"git solution" of using one's email address one's canonical, unique
identifier. It's a little silly in the centralized case, but in the
decentralized case, you don't really have control over who's committing
what, and when. So I'm happy with the fact that you can alias people,
because that will be helpful, but I don't want to make that the
canonical identifier.

But you're right in that the current comparison is of the full whoami
string, and it should probably be of the email address only.
-- 
William <wmorgan-ditz at masanjin.net>


More information about the ditz-talk mailing list