From jeff at zilkey.com Sun Jun 22 18:34:08 2008 From: jeff at zilkey.com (Jeff Dean) Date: Sun, 22 Jun 2008 18:34:08 -0400 Subject: [Desert-devel] Can't get specs to run Message-ID: <09463521-21E8-4F16-A2F4-52146487B428@zilkey.com> I committed a patch a while back that allowed for migrations to allow for a symbol as well as a string. At the time I committed, the specs passed. It looks like part of an earlier commit made it into the master branch, and causes migrations to fails. I've got the fix for it, and I want to verify it by running specs, but specs won't run. I've installed dependencies, and when I run rake I get: Running /Users/jeff/Sites/gems/desert/spec/unit_spec_suite.rb for Rails version edge ................................................................................................F . 1) ActiveRecord::ConnectionNotEstablished in 'ActiveRecord::Migration::DesertMigration#schema_version_equivalent_to sets the current plugin to the plugin referenced by the migration' ActiveRecord::ConnectionNotEstablished /Users/jeff/Sites/gems/desert/spec/../lib/desert/plugin_migrations/ migrator.rb:38:in `set_schema_version' /Users/jeff/Sites/gems/desert/spec/../lib/desert/rails/migration.rb: 14:in `schema_version_equivalent_to' /Users/jeff/Sites/gems/desert/spec/desert/rails/migration_spec.rb:34: /Users/jeff/Sites/gems/desert/spec/unit_spec_suite.rb:11: Finished in 0.691907 seconds 98 examples, 1 failure /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:21:in `run_with_rails_version': Failed for version edge (RuntimeError) from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:12:in `run' from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:8:in `each' from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:8:in `run' from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:6:in `each' from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:6:in `run' from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:26 rake aborted! Example Suite failed /Users/jeff/Sites/gems/desert/rakefile:20:in `run_suite' Is anyone else having that problem? Jeff From brian.takita at gmail.com Sun Jun 22 22:26:18 2008 From: brian.takita at gmail.com (Brian Takita) Date: Sun, 22 Jun 2008 19:26:18 -0700 Subject: [Desert-devel] Can't get specs to run In-Reply-To: <09463521-21E8-4F16-A2F4-52146487B428@zilkey.com> References: <09463521-21E8-4F16-A2F4-52146487B428@zilkey.com> Message-ID: <1d7ddd110806221926t1e4c91b5t762ac6db72a2c076@mail.gmail.com> On Sun, Jun 22, 2008 at 3:34 PM, Jeff Dean wrote: > I committed a patch a while back that allowed for migrations to allow for a > symbol as well as a string. At the time I committed, the specs passed. It > looks like part of an earlier commit made it into the master branch, and > causes migrations to fails. I've got the fix for it, and I want to verify > it by running specs, but specs won't run. I've installed dependencies, and > when I run rake I get: > > Running /Users/jeff/Sites/gems/desert/spec/unit_spec_suite.rb for Rails > version edge > ................................................................................................F. > > 1) > ActiveRecord::ConnectionNotEstablished in > 'ActiveRecord::Migration::DesertMigration#schema_version_equivalent_to sets > the current plugin to the plugin referenced by the migration' > ActiveRecord::ConnectionNotEstablished > /Users/jeff/Sites/gems/desert/spec/../lib/desert/plugin_migrations/migrator.rb:38:in > `set_schema_version' > /Users/jeff/Sites/gems/desert/spec/../lib/desert/rails/migration.rb:14:in > `schema_version_equivalent_to' > /Users/jeff/Sites/gems/desert/spec/desert/rails/migration_spec.rb:34: > /Users/jeff/Sites/gems/desert/spec/unit_spec_suite.rb:11: > > Finished in 0.691907 seconds > > 98 examples, 1 failure > /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:21:in > `run_with_rails_version': Failed for version edge (RuntimeError) > from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:12:in `run' > from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:8:in `each' > from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:8:in `run' > from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:6:in `each' > from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:6:in `run' > from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:26 > rake aborted! > Example Suite failed > /Users/jeff/Sites/gems/desert/rakefile:20:in `run_suite' > > Is anyone else having that problem? Yes I am. I had some merge issues with the svn repo. I also switched to a sqlite db for testing. I'll fix it. > > Jeff Thanks, Brian > _______________________________________________ > Desert-devel mailing list > Desert-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/desert-devel > From brian.takita at gmail.com Mon Jun 23 00:23:11 2008 From: brian.takita at gmail.com (Brian Takita) Date: Sun, 22 Jun 2008 21:23:11 -0700 Subject: [Desert-devel] Can't get specs to run In-Reply-To: <1d7ddd110806221926t1e4c91b5t762ac6db72a2c076@mail.gmail.com> References: <09463521-21E8-4F16-A2F4-52146487B428@zilkey.com> <1d7ddd110806221926t1e4c91b5t762ac6db72a2c076@mail.gmail.com> Message-ID: <1d7ddd110806222123p76b50875wa3b029264bdbae62@mail.gmail.com> On Sun, Jun 22, 2008 at 7:26 PM, Brian Takita wrote: > On Sun, Jun 22, 2008 at 3:34 PM, Jeff Dean wrote: >> I committed a patch a while back that allowed for migrations to allow for a >> symbol as well as a string. At the time I committed, the specs passed. It >> looks like part of an earlier commit made it into the master branch, and >> causes migrations to fails. I've got the fix for it, and I want to verify >> it by running specs, but specs won't run. I've installed dependencies, and >> when I run rake I get: >> >> Running /Users/jeff/Sites/gems/desert/spec/unit_spec_suite.rb for Rails >> version edge >> ................................................................................................F. >> >> 1) >> ActiveRecord::ConnectionNotEstablished in >> 'ActiveRecord::Migration::DesertMigration#schema_version_equivalent_to sets >> the current plugin to the plugin referenced by the migration' >> ActiveRecord::ConnectionNotEstablished >> /Users/jeff/Sites/gems/desert/spec/../lib/desert/plugin_migrations/migrator.rb:38:in >> `set_schema_version' >> /Users/jeff/Sites/gems/desert/spec/../lib/desert/rails/migration.rb:14:in >> `schema_version_equivalent_to' >> /Users/jeff/Sites/gems/desert/spec/desert/rails/migration_spec.rb:34: >> /Users/jeff/Sites/gems/desert/spec/unit_spec_suite.rb:11: >> >> Finished in 0.691907 seconds >> >> 98 examples, 1 failure >> /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:21:in >> `run_with_rails_version': Failed for version edge (RuntimeError) >> from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:12:in `run' >> from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:8:in `each' >> from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:8:in `run' >> from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:6:in `each' >> from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:6:in `run' >> from /Users/jeff/Sites/gems/desert/spec/spec_suite.rb:26 >> rake aborted! >> Example Suite failed >> /Users/jeff/Sites/gems/desert/rakefile:20:in `run_suite' >> >> Is anyone else having that problem? > Yes I am. I had some merge issues with the svn repo. > I also switched to a sqlite db for testing. I'll fix it. Ok, its fixed now. >> >> Jeff > Thanks, > Brian >> _______________________________________________ >> Desert-devel mailing list >> Desert-devel at rubyforge.org >> http://rubyforge.org/mailman/listinfo/desert-devel >> > From brian.takita at gmail.com Mon Jun 23 02:44:51 2008 From: brian.takita at gmail.com (Brian Takita) Date: Sun, 22 Jun 2008 23:44:51 -0700 Subject: [Desert-devel] Shocker (at least to me) - The Rails Engines plugin is very similar to Desert Message-ID: <1d7ddd110806222344s75eeeb7bk86ae7695cd1a8230@mail.gmail.com> Hello, Please take a look at the comments of my Desert blog post. http://pivots.pivotallabs.com/users/brian/blog/articles/459-build-your-own-rails-plugin-platform-with-desert Apparently Rails Engines has evolved to look a lot like Desert. The major difference that I see so far is how the file multi-loading works. Does anybody have recent experience with Rails Engines? If so, are there any other differences between these projects? If there aren't any other major differences, then it may be worth it to deprecate Desert and submit the relevant patches into Rails Engines. Thanks, Brian