From thewoolleyman at gmail.com  Mon Feb  1 00:50:03 2010
From: thewoolleyman at gmail.com (Chad Woolley)
Date: Sun, 31 Jan 2010 22:50:03 -0700
Subject: [Cruisecontrolrb-developers] Caching?
In-Reply-To: <3945c4271001270934i3c241cc5tcc17b397447e0b8d@mail.gmail.com>
References: <e3af97511001010239r5fba283fr6b9f2a280df4f56a@mail.gmail.com> 
	<a88396cb1001150854q60b67954w3c2b46ca84a22dd3@mail.gmail.com> 
	<e3af97511001270208g535eef84t1ce9da41e3488afe@mail.gmail.com> 
	<3945c4271001270915t1d35f7b0q4c9a048ac6b5e5b3@mail.gmail.com> 
	<a88396cb1001270924w54ab2734m191db2085b3f95cc@mail.gmail.com> 
	<3945c4271001270934i3c241cc5tcc17b397447e0b8d@mail.gmail.com>
Message-ID: <e3af97511001312150j2a81d3f6md7479e9b6d935c6e@mail.gmail.com>

On Wed, Jan 27, 2010 at 10:34 AM, Alexey Verkhovsky
<alexey.verkhovsky at gmail.com> wrote:
> Keep in mind that you'd have to also cache a collection of projects
> instances used by the frontend, and that this cache should handle
> adding/deleting/renaming of projects.

I've got a very simple implementation here:

http://github.com/thewoolleyman/cruisecontrol.rb/tree/caching

I think there's still some problems (doesn't clear on server startup,
but it should, I'll look into it).

If this is combined with a cron job run every minute or two to delete
the cache files, I think it will work fine to keep excessive load from
killing the server.

Let me know what you think.

-- Chad

From thewoolleyman at gmail.com  Mon Feb  1 00:54:12 2010
From: thewoolleyman at gmail.com (Chad Woolley)
Date: Sun, 31 Jan 2010 22:54:12 -0700
Subject: [Cruisecontrolrb-developers] Disabling disabling of build button?
Message-ID: <e3af97511001312154j617467dfy31845714ea9adbf8@mail.gmail.com>

Hi,

I always have problems with the build not button being disabled when
it shouldn't be.  It's something with the ajax call it makes not
coming back, I suspect.  This seems even worse when caching is enabled
for the projects page.

I'd like to add a config flag to optionally disable the build button
auto-disable behavior.  This just means multiple build POST requests
could get submitted, but this isn't a problem, is it?  The server
should ignore them if a build is in progress (I assume this is already
the case, haven't looked closely).

Thoughts?

Thanks,
-- Chad

From bguthrie at thoughtworks.com  Mon Feb  1 12:28:29 2010
From: bguthrie at thoughtworks.com (Brian Guthrie)
Date: Mon, 1 Feb 2010 09:28:29 -0800
Subject: [Cruisecontrolrb-developers] Caching?
In-Reply-To: <e3af97511001312150j2a81d3f6md7479e9b6d935c6e@mail.gmail.com>
References: <e3af97511001010239r5fba283fr6b9f2a280df4f56a@mail.gmail.com> 
	<a88396cb1001150854q60b67954w3c2b46ca84a22dd3@mail.gmail.com> 
	<e3af97511001270208g535eef84t1ce9da41e3488afe@mail.gmail.com> 
	<3945c4271001270915t1d35f7b0q4c9a048ac6b5e5b3@mail.gmail.com> 
	<a88396cb1001270924w54ab2734m191db2085b3f95cc@mail.gmail.com> 
	<3945c4271001270934i3c241cc5tcc17b397447e0b8d@mail.gmail.com> 
	<e3af97511001312150j2a81d3f6md7479e9b6d935c6e@mail.gmail.com>
Message-ID: <646a09521002010928o2053890co8fae23b8ed84c545@mail.gmail.com>

Would the administrator of the server have to set up the cron job
independently? That's kind of a bummer. Would it be worth the added overhead
of spinning up an async worker dedicated to it?

Brian

On Sun, Jan 31, 2010 at 9:50 PM, Chad Woolley <thewoolleyman at gmail.com>wrote:

> On Wed, Jan 27, 2010 at 10:34 AM, Alexey Verkhovsky
> <alexey.verkhovsky at gmail.com> wrote:
> > Keep in mind that you'd have to also cache a collection of projects
> > instances used by the frontend, and that this cache should handle
> > adding/deleting/renaming of projects.
>
> I've got a very simple implementation here:
>
> http://github.com/thewoolleyman/cruisecontrol.rb/tree/caching
>
> I think there's still some problems (doesn't clear on server startup,
> but it should, I'll look into it).
>
> If this is combined with a cron job run every minute or two to delete
> the cache files, I think it will work fine to keep excessive load from
> killing the server.
>
> Let me know what you think.
>
> -- Chad
> _______________________________________________
> Cruisecontrolrb-developers mailing list
> Cruisecontrolrb-developers at rubyforge.org
> http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/cruisecontrolrb-developers/attachments/20100201/7df42a08/attachment-0001.html>

From thewoolleyman at gmail.com  Mon Feb  1 12:52:44 2010
From: thewoolleyman at gmail.com (Chad Woolley)
Date: Mon, 1 Feb 2010 10:52:44 -0700
Subject: [Cruisecontrolrb-developers] Caching?
In-Reply-To: <646a09521002010928o2053890co8fae23b8ed84c545@mail.gmail.com>
References: <e3af97511001010239r5fba283fr6b9f2a280df4f56a@mail.gmail.com> 
	<a88396cb1001150854q60b67954w3c2b46ca84a22dd3@mail.gmail.com> 
	<e3af97511001270208g535eef84t1ce9da41e3488afe@mail.gmail.com> 
	<3945c4271001270915t1d35f7b0q4c9a048ac6b5e5b3@mail.gmail.com> 
	<a88396cb1001270924w54ab2734m191db2085b3f95cc@mail.gmail.com> 
	<3945c4271001270934i3c241cc5tcc17b397447e0b8d@mail.gmail.com> 
	<e3af97511001312150j2a81d3f6md7479e9b6d935c6e@mail.gmail.com> 
	<646a09521002010928o2053890co8fae23b8ed84c545@mail.gmail.com>
Message-ID: <e3af97511002010952w3f09bcc6n3497993d08cf7130@mail.gmail.com>

On Mon, Feb 1, 2010 at 10:28 AM, Brian Guthrie
<bguthrie at thoughtworks.com> wrote:
> Would the administrator of the server have to set up the cron job
> independently? That's kind of a bummer. Would it be worth the added overhead
> of spinning up an async worker dedicated to it?
> Brian

Yes.  I think that's sort of inherent with page caching to catch
anything that gets past your expiration rules.

I don't think it is worth the complexity to add asynch workers, a cron
job is much simpler.  I'm also not wanting to enable this by default
(a config flag?), so if anybody opts-in I'm assuming they can read
some docs describing the cron job, etc.

From alexey.verkhovsky at gmail.com  Tue Feb  2 11:21:40 2010
From: alexey.verkhovsky at gmail.com (Alexey Verkhovsky)
Date: Tue, 2 Feb 2010 09:21:40 -0700
Subject: [Cruisecontrolrb-developers] Disabling disabling of build
	button?
In-Reply-To: <e3af97511001312154j617467dfy31845714ea9adbf8@mail.gmail.com>
References: <e3af97511001312154j617467dfy31845714ea9adbf8@mail.gmail.com>
Message-ID: <3945c4271002020821p5987d641r5746ba2965bedd35@mail.gmail.com>

On Sun, Jan 31, 2010 at 10:54 PM, Chad Woolley <thewoolleyman at gmail.com>wrote:

> The server
> should ignore them if a build is in progress


As far as I recall, that's not the case.

-- 
Alexey Verkhovsky
http://alex-verkhovsky.blogspot.com/
CruiseControl.rb [http://cruisecontrolrb.thoughtworks.com]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/cruisecontrolrb-developers/attachments/20100202/fc602a51/attachment.html>

From thewoolleyman at gmail.com  Tue Feb  2 11:33:07 2010
From: thewoolleyman at gmail.com (Chad Woolley)
Date: Tue, 2 Feb 2010 09:33:07 -0700
Subject: [Cruisecontrolrb-developers] Disabling disabling of build
	button?
In-Reply-To: <3945c4271002020821p5987d641r5746ba2965bedd35@mail.gmail.com>
References: <e3af97511001312154j617467dfy31845714ea9adbf8@mail.gmail.com> 
	<3945c4271002020821p5987d641r5746ba2965bedd35@mail.gmail.com>
Message-ID: <e3af97511002020833t405a10dfp9e90a98ea0ccc1e9@mail.gmail.com>

On Tue, Feb 2, 2010 at 9:21 AM, Alexey Verkhovsky
<alexey.verkhovsky at gmail.com> wrote:
> On Sun, Jan 31, 2010 at 10:54 PM, Chad Woolley <thewoolleyman at gmail.com>
> wrote:
>>
>> The server
>> should ignore them if a build is in progress
>
> As far as I recall, that's not the case.

Really?  Then it doesn't seem like it would matter if you control it
on the client anyway, because two separate clients could still click
the button simultaneously.

From thewoolleyman at gmail.com  Sun Feb 28 16:26:02 2010
From: thewoolleyman at gmail.com (Chad Woolley)
Date: Sun, 28 Feb 2010 14:26:02 -0700
Subject: [Cruisecontrolrb-developers] How about we turn off pull requests
	(Was: [GitHub] gnufied sent you a pull request from
	gnufied/cruisecontrol.rb)
Message-ID: <e3af97511002281326o45d16759q80e078b178a54513@mail.gmail.com>

How about we turn off pull requests with message asking for
patch+ticket?  Since github doesn't allow non-account-owners to view
pull requests, that's the only way to allow all the collaborators to
help manage tickets/patches.


---------- Forwarded message ----------
From: GitHub <noreply at github.com>
Date: Mon, Jan 25, 2010 at 12:52 PM
Subject: [GitHub] gnufied sent you a pull request from gnufied/cruisecontrol.rb
To: thewoolleyman at gmail.com




gnufied wants you to pull from gnufied/cruisecontrol.rb at master

Body: Can you guys pull in from my fork? I have done two things:

1. Do not load smtl_tls.rb for Ruby 1.8.7.
2. Implement twitter support via plugin.

There are test cases to cover the functionality as well (and thus
shouldn't be a problem to merge).


View repository: http://github.com/gnufied/cruisecontrol.rb/tree/master