[Borges-users] HtmlBuilder#image_url_anchor and HtmlRenderer#image_anchor

[Kaspar Schiess]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Eric Hodel wrote:

| Perhaps there should be a default set of stylesheet rules provided with
| Borges to remove things like image borders for links?  (Almost all of my
| stylesheets have an img { border: 0; } rule.)

You are right. I will leave the setting of image borders out. This
forces everyone to have the rule you mention in their stylesheets; but
it probably is there anyway because that really is a feature that one
uses rarely.

I will not mention this detail in the documentation, since it seems
pretty clear to me that one should be doing this.

I will check in the patch I have posted without the setting of border.
Changes are to HtmlBuilder.rb, HtmlRenderer.rb, HtmlBuilderTest.rb and
HtmlRendererTest.rb:

Checking in lib/Borges/HTML/HtmlBuilder.rb;
/var/cvs/borges/borges/lib/Borges/HTML/HtmlBuilder.rb,v  <--  HtmlBuilder.rb
new revision: 1.29; previous revision: 1.28
done
Checking in lib/Borges/HTML/HtmlRenderer.rb;
/var/cvs/borges/borges/lib/Borges/HTML/HtmlRenderer.rb,v  <--
HtmlRenderer.rb
new revision: 1.26; previous revision: 1.25
done
Checking in lib/Borges/TestCase/HtmlBuilderTest.rb;
/var/cvs/borges/borges/lib/Borges/TestCase/HtmlBuilderTest.rb,v  <--
HtmlBuilderTest.rb
new revision: 1.12; previous revision: 1.11
done
Checking in lib/Borges/TestCase/HtmlRendererTest.rb;
/var/cvs/borges/borges/lib/Borges/TestCase/HtmlRendererTest.rb,v  <--
HtmlRendererTest.rb
new revision: 1.9; previous revision: 1.8
done

There is one thing left that bugs me, but I see no way of fixing that:
image_url_anchor(url, src, alt='')
One would expect parameter order of src, alt, url since the name
mentions first the image and then the anchor.

best regards,

kaspar - code philosopher

- -- stolen off the net --
"All in all, 'reality' is a nice concept, but it still needs some fine
tuning. For information how to finetune 'reality', read the alt.drugs.*
newsgroups."
		-- Stefan Hermes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAi97mFifl4CA0ImQRAhX1AJ9owKtc4gP/cf2V5h/+gX9/iBbARwCfYy9p
aQjgoa/e+J1c8Xsj3zflLDU=
=U8ue
-----END PGP SIGNATURE-----