[Borges-users] Patches, Proposals: Patch for current CVS

[Eric Hodel]

Kaspar Schiess (eule at space.ch) wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hello Eric,
> 
> Thanks for considering my monster post.
> 
> | I'll do my best to comment on these, but it'd be easier if there was one
> | email per issue.  It also makes it easier to commit the patches I
> | accept right away.
> Ok. Sometimes things accumulate ;)
> 
> |>a) Introduction of text_area_on analoguous to text_input_on.
>
> patch is called 040401-borges-textarea.diff

Checked in.

> |>c) Introduction of more verbous error output if Borges cannot find a
> |>continuation to call.
> | Ok, tentatively.  When do you run into this problem?
> 
> Problem surfaces when user forgets (silly me) the use of radio_group.
> While this should throw an error, it should be less cryptic than what
> the code now outputs. What I submit here is what helped me find the bug
> in my code.
> 
> 040401-borges-verbosity.diff

Checked in.

> |>e) Borges::Path should now work. Can anyone explain to me how to use
> |>this properly ?
> |
> |
> | Ugh, it suffers from being to Smalltalkish.  I can clean up your patch,
> | too.
> |
> | I think you can use Borges::Path for breadcrumbs.
> 
> I am using it for that, however the application architecture that one
> needs for this is not clear to me. I submit my path.rb in whole, for you
> to clean it up. (040401-borges-path.diff)

I'll ask on the Seaside list.

Checked in.

> Some other small issues to make your CVS copy identical to my working
> copy are in 040401-borges-various.diff. You will give me your opinion on
> those; especially the introduction of xhtml doctype is something to talk
> about.

All of these but the XHTML doctype checked in.

I'm fairly sure that the pages built into Borges right now wouldn't pass
the validator, so I'm hesitant to add any doctype at all at this time.

While I plan to have all the built in components emit valid markup, I
don't feel XHTML is the best doctype to use, and plan to use HTML4
Transitional, in order to favor those application authors too lazy to
use properly semantic HTML.

-- 
Eric Hodel - drbrain at segment7.net - http://segment7.net
All messages signed with fingerprint:
FEC2 57F1 D465 EB15 5D6E  7C11 332A 551C 796C 9F04

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/borges-users/attachments/20040404/7dbe6420/attachment.bin