[Borges-users] Extension of BatchedList

[Kaspar Schiess]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Eric,

| A better name is needed, since "Extended" isn't very descriptive.
| Perhaps something like Limited or (I thought of something almost there,
| but I've since lost it).
Tell me when it comes back ;) I will gladly change the name: 'Extended'
just reflects my vagueness about the name. Could it be 'Environmented' ?
Or just 'Limited' like you say. Or probably 'Big' ?

| Fix comment to read something like:
Done.

|     while f < max_pages do
|       if (n + 1) % f == 0 && (current_page - n).abs < environment*f then
|         return true
|       end
|
| I always use the do and then keywords, and I always have space between
| operators.  (The indent looks funny because of the tab.)
I'd be inclined to not use 'do' and 'then' when they are implicit. Also
I would use spacing of operators as a means of expressing grouping like:
(n+1) % f   or
(current_page-n).abs < environment*f

But I will take care to align with you on these issues. Allow me to
create a small coding standards document.


| If you'd like, you can omit () if unneeded.  I plan on removing them in
| methods I touch, since they're just leftovers from the port from
| Seaside.
ok.

Thank you for your code review. Attached a .tgz-pped version of the result.

kaspar - code philosopher

- -- stolen off the net --
~ > Can you see evidence of aliens on the moon as well ???
You can see evidence of aliens in your oatmeal, if you look with the
right mindset and expectations.
		-- Jeramie Hicks, in sci.space.policy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAa86Sh6tlx0BWOuARAomvAJ9xSqpwweIa1EZbh467kFIqICSTNwCcCQnS
Fgfv+lvpnXWz6AWC5Ywvj1Y=
=wpjy
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 040401-extbatchedlist.tgz
Type: application/x-compressed
Size: 1113 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/borges-users/attachments/20040401/2c8ca71f/040401-extbatchedlist.bin