[BioCatalogue-developers] [Fwd: [ biocatalogue-Bugs-26258 ] account confirmation email points to localhost]

[Jiten Bhagat]

Okay, I figured that would be the case.

But the "right" way to do it, and its fairly simple, is what I suggested 
in my email below. That will ensure it works on any deployment.

Locally modifying svn'ed files is a recipe for disaster :-(

Jits


Thomas Laurent wrote:
> It worked so far because they were using the right url.
> But I guess last week when we had the pb with svn, we removed the 
> entire directory and checked it out again. The pb is I didn't want to 
> check EBI specific urls, so what was checked in was the url using 
> localhost.
>
> I'll put back the right urls.
>
> Jiten Bhagat wrote:
>> This needs to be sorted asap please (see below).
>>
>> Looking at the mailer templates:
>>
>> http://biocatalogue.rubyforge.org/svn/trunk/app/views/user_mailer/registration_notification.html.erb 
>>
>> http://biocatalogue.rubyforge.org/svn/trunk/app/views/user_mailer/reset_password.html.erb 
>>
>>
>> ... the host name and port has been hard coded into the templates 
>> (!!). How have users been able to register and activate their account 
>> so far?
>>
>> One way of solving this problem is to automatically figure out the 
>> base_uri and then pass it into the mailer template.
>>
>> In myExperiment we do this by defining a method like this in the 
>> application_controller.rb:
>>
>> def base_host
>>  request.host_with_port
>> end
>>
>> And then when calling the mailer we pass this into the template like eg:
>>
>> Mailer.deliver_account_confirmation(@user, 
>> confirmation_hash(@user.unconfirmed_email), base_host)
>>
>> And the final email template looks like this:
>>
>> http://myexperiment.rubyforge.org/svn/trunk/app/views/mailer/account_confirmation.rhtml 
>>
>>
>> Please can we fix this today and also do up the mail templates to 
>> look more professional.
>>
>> Thanks,
>> Jits
>>
>>
>> -------- Original Message --------
>> Subject:     [BioCatalogue-developers] [ biocatalogue-Bugs-26258 ] 
>> account confirmation email points to localhost
>> Date:     Wed, 17 Jun 2009 06:48:40 -0400 (EDT)
>> From:     <noreply at rubyforge.org>
>> To:     noreply at rubyforge.org
>>
>>
>>
>> Bugs item #26258, was opened at 2009-06-17 06:48
>> You can respond by visiting: 
>> http://rubyforge.org/tracker/?func=detail&atid=26756&aid=26258&group_id=6901 
>>
>>
>> Category: None
>> Group: None
>> Status: Open
>> Resolution: None
>> Priority: 3
>> Submitted By: Nobody (None)
>> Assigned to: Nobody (None)
>> Summary: account confirmation email points to localhost
>>
>> Initial Comment:
>> Content of the email I just received:
>>
>> Please, click on the following link to activate your account.
>> http://localhost:3005/activate_account/ff874b7dfa115620b077d24cf7f1553640294951 
>>
>>
>> ----------------------------------------------------------------------
>>
>> You can respond by visiting: 
>> http://rubyforge.org/tracker/?func=detail&atid=26756&aid=26258&group_id=6901 
>>
>> _______________________________________________
>> BioCatalogue-developers mailing list
>> BioCatalogue-developers at rubyforge.org
>> http://rubyforge.org/mailman/listinfo/biocatalogue-developers