From dontfall at gmail.com  Tue Nov  7 10:02:26 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Tue, 7 Nov 2006 10:02:26 -0500
Subject: [Betternestedset-talk] Better nested set
In-Reply-To: <d635202b1cfee41bc75019de38102ed0@symetrie.com>
References: <8d64b97d0611061355s164baccelb2c2478b2d80cba9@mail.gmail.com>
	<d635202b1cfee41bc75019de38102ed0@symetrie.com>
Message-ID: <8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>

Hi Jean-Christophe,

Thanks for writing back-- I'm using the betternestedset mailing list now.

Ah, I just looked at rubyforge and see that the code there has tests.

> I'd like to build tests in the same was as
> http://svn.viney.net.nz/things/rails/plugins/acts_as_modified
> It's probably a good model to follow.

OK, let me know if I have this right:
1) If I want to contribute, I should work from the source  code on
rubyforge, not trac.
2) You are not happy with the current tests, and would instead like
them to follow the model of acts_as_modified.

Do you want me to start changing the tests, or is Tim Olsen still in
charge of that? I don't want to disrupt someone else's work.

Let me know how I can be helpful.

Cheers,
Krishna


On 11/6/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> Hi Krishna,
>
> Le 6 nov. 06, ? 22:55, Krishna Dole a ?crit :
> > First of all, thanks for improving nested set and moving it to a
> > plugin.
>
> Thks
>
> > Your 'better nested set' looks promising, and I'd like to help with
> > it.
>
> You're welcome.
>
> > Before I start submitting patches, did you have a plan for how you
> > want the tests set up?
>
> Tim Olsen began to help me too. He committed a bunch of things in the
> rubyforge svn. I think it's not appropriate.
> I'd like to build tests in the same was as
> http://svn.viney.net.nz/things/rails/plugins/acts_as_modified
> It's probably a good model to follow.
>
> Ah, and I kept trac on opensource.symetrie.com/better_nested_set while
> other functions are on rubyforge, because I like trac ;-)
> Do you know if we need a special setting in svn to be able to use
> script/plugin install ?
>
>
> PS: can we continue this discussion on the rubyforge betternestedset
> mailling list ?
> So it"ll be archived.
>
> Jean-Christophe Michel
> --
> Sym?trie, ?dition de musique et services multim?dia
> 30 rue Jean-Baptiste Say
> 69001 LYON (FRANCE)
> t?l +33 (0)478 29 52 14
> fax +33 (0)478 30 01 11
> web www.symetrie.com
>
>

From dontfall at gmail.com  Tue Nov  7 13:40:36 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Tue, 7 Nov 2006 13:40:36 -0500
Subject: [Betternestedset-talk] Better nested set
In-Reply-To: <8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
References: <8d64b97d0611061355s164baccelb2c2478b2d80cba9@mail.gmail.com>
	<d635202b1cfee41bc75019de38102ed0@symetrie.com>
	<8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
Message-ID: <8d64b97d0611071040u7d4f3f0fkf0da667d4566b9ea@mail.gmail.com>

Oops-- forgot to answer your svn install question:
> Do you know if we need a special setting in svn to be able to use
> script/plugin install ?

It looks like everything is set up correctly for rubyforge, since the
following two commands installed the plugin into a rails project for
me:

script/plugin source svn://rubyforge.org/var/svn/betternestedset
script/plugin install betternestedset

Is this what you were asking about?
Or were you asking about Trac?

k

PS-- I don't know if you're having the same problem, but the
betternestedset-talk mailing list seems to be taking forever to
deliver emails to me. They show up in the list archives, but not in my
in-box.



On 11/7/06, Krishna Dole <dontfall at gmail.com> wrote:
> Hi Jean-Christophe,
>
> Thanks for writing back-- I'm using the betternestedset mailing list now.
>
> Ah, I just looked at rubyforge and see that the code there has tests.
>
> > I'd like to build tests in the same was as
> > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified
> > It's probably a good model to follow.
>
> OK, let me know if I have this right:
> 1) If I want to contribute, I should work from the source  code on
> rubyforge, not trac.
> 2) You are not happy with the current tests, and would instead like
> them to follow the model of acts_as_modified.
>
> Do you want me to start changing the tests, or is Tim Olsen still in
> charge of that? I don't want to disrupt someone else's work.
>
> Let me know how I can be helpful.
>
> Cheers,
> Krishna
>
>
> On 11/6/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> > Hi Krishna,
> >
> > Le 6 nov. 06, ? 22:55, Krishna Dole a ?crit :
> > > First of all, thanks for improving nested set and moving it to a
> > > plugin.
> >
> > Thks
> >
> > > Your 'better nested set' looks promising, and I'd like to help with
> > > it.
> >
> > You're welcome.
> >
> > > Before I start submitting patches, did you have a plan for how you
> > > want the tests set up?
> >
> > Tim Olsen began to help me too. He committed a bunch of things in the
> > rubyforge svn. I think it's not appropriate.
> > I'd like to build tests in the same was as
> > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified
> > It's probably a good model to follow.
> >
> > Ah, and I kept trac on opensource.symetrie.com/better_nested_set while
> > other functions are on rubyforge, because I like trac ;-)
> > Do you know if we need a special setting in svn to be able to use
> > script/plugin install ?
> >
> >
> > PS: can we continue this discussion on the rubyforge betternestedset
> > mailling list ?
> > So it"ll be archived.
> >
> > Jean-Christophe Michel
> > --
> > Sym?trie, ?dition de musique et services multim?dia
> > 30 rue Jean-Baptiste Say
> > 69001 LYON (FRANCE)
> > t?l +33 (0)478 29 52 14
> > fax +33 (0)478 30 01 11
> > web www.symetrie.com
> >
> >
>

From tolsen718 at gmail.com  Tue Nov  7 16:58:33 2006
From: tolsen718 at gmail.com (Tim Olsen)
Date: Tue, 7 Nov 2006 16:58:33 -0500
Subject: [Betternestedset-talk] Better nested set
In-Reply-To: <4be80d840611071357w7b9817a2w25957a4741536981@mail.gmail.com>
References: <8d64b97d0611061355s164baccelb2c2478b2d80cba9@mail.gmail.com>
	<d635202b1cfee41bc75019de38102ed0@symetrie.com>
	<8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
	<4be80d840611071357w7b9817a2w25957a4741536981@mail.gmail.com>
Message-ID: <4be80d840611071358k13d8456elc33feddcef56497c@mail.gmail.com>

oops. forgot to reply to all.

-Tim

On 11/7/06, Tim Olsen <tolsen718 at gmail.com> wrote:
> Feel free to scrap most of my work and start afresh.  Jean-Christophe
> convinced me I was going about it the wrong way.
>
> Cheers,
> Tim
>
> On 11/7/06, Krishna Dole <dontfall at gmail.com> wrote:
> > Hi Jean-Christophe,
> >
> > Thanks for writing back-- I'm using the betternestedset mailing list now.
> >
> > Ah, I just looked at rubyforge and see that the code there has tests.
> >
> > > I'd like to build tests in the same was as
> > > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified
> > > It's probably a good model to follow.
> >
> > OK, let me know if I have this right:
> > 1) If I want to contribute, I should work from the source  code on
> > rubyforge, not trac.
> > 2) You are not happy with the current tests, and would instead like
> > them to follow the model of acts_as_modified.
> >
> > Do you want me to start changing the tests, or is Tim Olsen still in
> > charge of that? I don't want to disrupt someone else's work.
> >
> > Let me know how I can be helpful.
> >
> > Cheers,
> > Krishna
> >
> >
> > On 11/6/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> > > Hi Krishna,
> > >
> > > Le 6 nov. 06, ? 22:55, Krishna Dole a ?crit :
> > > > First of all, thanks for improving nested set and moving it to a
> > > > plugin.
> > >
> > > Thks
> > >
> > > > Your 'better nested set' looks promising, and I'd like to help with
> > > > it.
> > >
> > > You're welcome.
> > >
> > > > Before I start submitting patches, did you have a plan for how you
> > > > want the tests set up?
> > >
> > > Tim Olsen began to help me too. He committed a bunch of things in the
> > > rubyforge svn. I think it's not appropriate.
> > > I'd like to build tests in the same was as
> > > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified
> > > It's probably a good model to follow.
> > >
> > > Ah, and I kept trac on opensource.symetrie.com/better_nested_set while
> > > other functions are on rubyforge, because I like trac ;-)
> > > Do you know if we need a special setting in svn to be able to use
> > > script/plugin install ?
> > >
> > >
> > > PS: can we continue this discussion on the rubyforge betternestedset
> > > mailling list ?
> > > So it"ll be archived.
> > >
> > > Jean-Christophe Michel
> > > --
> > > Sym?trie, ?dition de musique et services multim?dia
> > > 30 rue Jean-Baptiste Say
> > > 69001 LYON (FRANCE)
> > > t?l +33 (0)478 29 52 14
> > > fax +33 (0)478 30 01 11
> > > web www.symetrie.com
> > >
> > >
> > _______________________________________________
> > Betternestedset-talk mailing list
> > Betternestedset-talk at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/betternestedset-talk
> >
>

From jc.michel at symetrie.com  Tue Nov  7 17:29:43 2006
From: jc.michel at symetrie.com (Jean-Christophe Michel)
Date: Tue, 7 Nov 2006 23:29:43 +0100
Subject: [Betternestedset-talk] Better nested set
In-Reply-To: <8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
References: <8d64b97d0611061355s164baccelb2c2478b2d80cba9@mail.gmail.com>
	<d635202b1cfee41bc75019de38102ed0@symetrie.com>
	<8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
Message-ID: <946fd404102f8bbe15f0665feeddf79f@symetrie.com>

Hi Krishna,


> OK, let me know if I have this right:
> 1) If I want to contribute, I should work from the source  code on
> rubyforge, not trac.
> 2) You are not happy with the current tests, and would instead like
> them to follow the model of acts_as_modified.
>
> Do you want me to start changing the tests, or is Tim Olsen still in
> charge of that? I don't want to disrupt someone else's work.

Good idea, since Tim agrees.
Feel free to start from either code you prefer, the plugin code is the 
same, I think only tests and vendor/ are added into rubyforge.
Add  yourself to rubyforge, send your id and I'll add it to the admin 
so you'll be able to commit.
Or if you're not familiar with svn, send patches here and we'll commit.

Jean-Christophe Michel
--
symetrie.com

Better Nested Set for rails:
http://opensource.symetrie.com/trac/better_nested_set


From jc.michel at symetrie.com  Tue Nov  7 17:59:03 2006
From: jc.michel at symetrie.com (Jean-Christophe Michel)
Date: Tue, 7 Nov 2006 23:59:03 +0100
Subject: [Betternestedset-talk] Better nested set
In-Reply-To: <8d64b97d0611071040u7d4f3f0fkf0da667d4566b9ea@mail.gmail.com>
References: <8d64b97d0611061355s164baccelb2c2478b2d80cba9@mail.gmail.com>
	<d635202b1cfee41bc75019de38102ed0@symetrie.com>
	<8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
	<8d64b97d0611071040u7d4f3f0fkf0da667d4566b9ea@mail.gmail.com>
Message-ID: <b21b9b4cebb79ad9c7dae072b4db096a@symetrie.com>

Hi,

Le 7 nov. 06, ? 19:40, Krishna Dole a ?crit :

> Oops-- forgot to answer your svn install question:
>> Do you know if we need a special setting in svn to be able to use
>> script/plugin install ?
>
> It looks like everything is set up correctly for rubyforge, since the
> following two commands installed the plugin into a rails project for
> me:
>
> script/plugin source svn://rubyforge.org/var/svn/betternestedset
> script/plugin install betternestedset
>
> Is this what you were asking about?

yes, good info. I'll add it on trac home page.

> PS-- I don't know if you're having the same problem, but the
> betternestedset-talk mailing list seems to be taking forever to
> deliver emails to me. They show up in the list archives, but not in my
> in-box.

True. Your mail arrived before my reply ;-)
I changed to rubyforge to be able to deliver gems, not having to handle 
a mailling list...
and spare some bandwidth if it becomes a success. But being able to 
work with the tools would be great ;p

Jean-Christophe Michel
--
symetrie.com

Better Nested Set for rails:
http://opensource.symetrie.com/trac/better_nested_set


From dontfall at gmail.com  Tue Nov  7 20:10:44 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Tue, 7 Nov 2006 20:10:44 -0500
Subject: [Betternestedset-talk] Better nested set
In-Reply-To: <4be80d840611071358k13d8456elc33feddcef56497c@mail.gmail.com>
References: <8d64b97d0611061355s164baccelb2c2478b2d80cba9@mail.gmail.com>
	<d635202b1cfee41bc75019de38102ed0@symetrie.com>
	<8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
	<4be80d840611071357w7b9817a2w25957a4741536981@mail.gmail.com>
	<4be80d840611071358k13d8456elc33feddcef56497c@mail.gmail.com>
Message-ID: <8d64b97d0611071710pc20d53ble08454036e41b6d2@mail.gmail.com>

Hi Tim,

OK, tomorrow I'll start trying to migrate the current tests to a new setup.

k

On 11/7/06, Tim Olsen <tolsen718 at gmail.com> wrote:
> oops. forgot to reply to all.
>
> -Tim
>
> On 11/7/06, Tim Olsen <tolsen718 at gmail.com> wrote:
> > Feel free to scrap most of my work and start afresh.  Jean-Christophe
> > convinced me I was going about it the wrong way.
> >
> > Cheers,
> > Tim
> >
> > On 11/7/06, Krishna Dole <dontfall at gmail.com> wrote:
> > > Hi Jean-Christophe,
> > >
> > > Thanks for writing back-- I'm using the betternestedset mailing list now.
> > >
> > > Ah, I just looked at rubyforge and see that the code there has tests.
> > >
> > > > I'd like to build tests in the same was as
> > > > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified
> > > > It's probably a good model to follow.
> > >
> > > OK, let me know if I have this right:
> > > 1) If I want to contribute, I should work from the source  code on
> > > rubyforge, not trac.
> > > 2) You are not happy with the current tests, and would instead like
> > > them to follow the model of acts_as_modified.
> > >
> > > Do you want me to start changing the tests, or is Tim Olsen still in
> > > charge of that? I don't want to disrupt someone else's work.
> > >
> > > Let me know how I can be helpful.
> > >
> > > Cheers,
> > > Krishna
> > >
> > >
> > > On 11/6/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> > > > Hi Krishna,
> > > >
> > > > Le 6 nov. 06, ? 22:55, Krishna Dole a ?crit :
> > > > > First of all, thanks for improving nested set and moving it to a
> > > > > plugin.
> > > >
> > > > Thks
> > > >
> > > > > Your 'better nested set' looks promising, and I'd like to help with
> > > > > it.
> > > >
> > > > You're welcome.
> > > >
> > > > > Before I start submitting patches, did you have a plan for how you
> > > > > want the tests set up?
> > > >
> > > > Tim Olsen began to help me too. He committed a bunch of things in the
> > > > rubyforge svn. I think it's not appropriate.
> > > > I'd like to build tests in the same was as
> > > > http://svn.viney.net.nz/things/rails/plugins/acts_as_modified
> > > > It's probably a good model to follow.
> > > >
> > > > Ah, and I kept trac on opensource.symetrie.com/better_nested_set while
> > > > other functions are on rubyforge, because I like trac ;-)
> > > > Do you know if we need a special setting in svn to be able to use
> > > > script/plugin install ?
> > > >
> > > >
> > > > PS: can we continue this discussion on the rubyforge betternestedset
> > > > mailling list ?
> > > > So it"ll be archived.
> > > >
> > > > Jean-Christophe Michel
> > > > --
> > > > Sym?trie, ?dition de musique et services multim?dia
> > > > 30 rue Jean-Baptiste Say
> > > > 69001 LYON (FRANCE)
> > > > t?l +33 (0)478 29 52 14
> > > > fax +33 (0)478 30 01 11
> > > > web www.symetrie.com
> > > >
> > > >
> > > _______________________________________________
> > > Betternestedset-talk mailing list
> > > Betternestedset-talk at rubyforge.org
> > > http://rubyforge.org/mailman/listinfo/betternestedset-talk
> > >
> >
>

From dontfall at gmail.com  Tue Nov  7 20:39:18 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Tue, 7 Nov 2006 20:39:18 -0500
Subject: [Betternestedset-talk] Better nested set
In-Reply-To: <8d64b97d0611071737k38a7370ama9ef7750abd9f41a@mail.gmail.com>
References: <8d64b97d0611061355s164baccelb2c2478b2d80cba9@mail.gmail.com>
	<d635202b1cfee41bc75019de38102ed0@symetrie.com>
	<8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
	<946fd404102f8bbe15f0665feeddf79f@symetrie.com>
	<8d64b97d0611071737k38a7370ama9ef7750abd9f41a@mail.gmail.com>
Message-ID: <8d64b97d0611071739x116c3d8ejeb9a11e4a35fdbf7@mail.gmail.com>

oops, forgot to send to the list...

On 11/7/06, Krishna Dole <dontfall at gmail.com> wrote:
> Hi Jean-Christophe,
>
> Great, thanks for being willing to add me as a developer. My rubyforge
> user ID is 12328 and my login name is kpd. I'm familiar with svn, so
> that should work fine.
>
> Messages to the list are still taking a while to get to me, so I
> apologize for delayed email tag.
>
> k
>
> On 11/7/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> > Hi Krishna,
> >
> >
> > > OK, let me know if I have this right:
> > > 1) If I want to contribute, I should work from the source  code on
> > > rubyforge, not trac.
> > > 2) You are not happy with the current tests, and would instead like
> > > them to follow the model of acts_as_modified.
> > >
> > > Do you want me to start changing the tests, or is Tim Olsen still in
> > > charge of that? I don't want to disrupt someone else's work.
> >
> > Good idea, since Tim agrees.
> > Feel free to start from either code you prefer, the plugin code is the
> > same, I think only tests and vendor/ are added into rubyforge.
> > Add  yourself to rubyforge, send your id and I'll add it to the admin
> > so you'll be able to commit.
> > Or if you're not familiar with svn, send patches here and we'll commit.
> >
> > Jean-Christophe Michel
> > --
> > symetrie.com
> >
> > Better Nested Set for rails:
> > http://opensource.symetrie.com/trac/better_nested_set
> >
> > _______________________________________________
> > Betternestedset-talk mailing list
> > Betternestedset-talk at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/betternestedset-talk
> >
>

From dontfall at gmail.com  Wed Nov  8 09:59:26 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Wed, 8 Nov 2006 09:59:26 -0500
Subject: [Betternestedset-talk] Better nested set
In-Reply-To: <946fd404102f8bbe15f0665feeddf79f@symetrie.com>
References: <8d64b97d0611061355s164baccelb2c2478b2d80cba9@mail.gmail.com>
	<d635202b1cfee41bc75019de38102ed0@symetrie.com>
	<8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
	<946fd404102f8bbe15f0665feeddf79f@symetrie.com>
Message-ID: <8d64b97d0611080659y665f24c7h74962c1845a24e74@mail.gmail.com>

Hi Jean-Christophe,

I've implemented the new test setup, but it looks like
better_nested_set isn't overriding the built-in nested set in rails
core. In other words the tests are all passing, but they aren't using
our nested set code.

Any ideas?

k

On 11/7/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> Hi Krishna,
>
>
> > OK, let me know if I have this right:
> > 1) If I want to contribute, I should work from the source  code on
> > rubyforge, not trac.
> > 2) You are not happy with the current tests, and would instead like
> > them to follow the model of acts_as_modified.
> >
> > Do you want me to start changing the tests, or is Tim Olsen still in
> > charge of that? I don't want to disrupt someone else's work.
>
> Good idea, since Tim agrees.
> Feel free to start from either code you prefer, the plugin code is the
> same, I think only tests and vendor/ are added into rubyforge.
> Add  yourself to rubyforge, send your id and I'll add it to the admin
> so you'll be able to commit.
> Or if you're not familiar with svn, send patches here and we'll commit.
>
> Jean-Christophe Michel
> --
> symetrie.com
>
> Better Nested Set for rails:
> http://opensource.symetrie.com/trac/better_nested_set
>
> _______________________________________________
> Betternestedset-talk mailing list
> Betternestedset-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/betternestedset-talk
>

From dontfall at gmail.com  Wed Nov  8 14:27:11 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Wed, 8 Nov 2006 14:27:11 -0500
Subject: [Betternestedset-talk] Better nested set
In-Reply-To: <8d64b97d0611080659y665f24c7h74962c1845a24e74@mail.gmail.com>
References: <8d64b97d0611061355s164baccelb2c2478b2d80cba9@mail.gmail.com>
	<d635202b1cfee41bc75019de38102ed0@symetrie.com>
	<8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
	<946fd404102f8bbe15f0665feeddf79f@symetrie.com>
	<8d64b97d0611080659y665f24c7h74962c1845a24e74@mail.gmail.com>
Message-ID: <8d64b97d0611081127m6c409ee5w42e17a0732a61c07@mail.gmail.com>

hang on... my mistake. i needed to mix the module into active record
in my abstract_unit.rb, since init.rb wasn't getting loaded in
testing.

k

On 11/8/06, Krishna Dole <dontfall at gmail.com> wrote:
> Hi Jean-Christophe,
>
> I've implemented the new test setup, but it looks like
> better_nested_set isn't overriding the built-in nested set in rails
> core. In other words the tests are all passing, but they aren't using
> our nested set code.
>
> Any ideas?
>
> k
>
> On 11/7/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> > Hi Krishna,
> >
> >
> > > OK, let me know if I have this right:
> > > 1) If I want to contribute, I should work from the source  code on
> > > rubyforge, not trac.
> > > 2) You are not happy with the current tests, and would instead like
> > > them to follow the model of acts_as_modified.
> > >
> > > Do you want me to start changing the tests, or is Tim Olsen still in
> > > charge of that? I don't want to disrupt someone else's work.
> >
> > Good idea, since Tim agrees.
> > Feel free to start from either code you prefer, the plugin code is the
> > same, I think only tests and vendor/ are added into rubyforge.
> > Add  yourself to rubyforge, send your id and I'll add it to the admin
> > so you'll be able to commit.
> > Or if you're not familiar with svn, send patches here and we'll commit.
> >
> > Jean-Christophe Michel
> > --
> > symetrie.com
> >
> > Better Nested Set for rails:
> > http://opensource.symetrie.com/trac/better_nested_set
> >
> > _______________________________________________
> > Betternestedset-talk mailing list
> > Betternestedset-talk at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/betternestedset-talk
> >
>

From dontfall at gmail.com  Wed Nov  8 17:07:38 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Wed, 8 Nov 2006 17:07:38 -0500
Subject: [Betternestedset-talk] Better nested set
In-Reply-To: <8d64b97d0611081127m6c409ee5w42e17a0732a61c07@mail.gmail.com>
References: <8d64b97d0611061355s164baccelb2c2478b2d80cba9@mail.gmail.com>
	<d635202b1cfee41bc75019de38102ed0@symetrie.com>
	<8d64b97d0611070702j500f8b36p1f5c2b457d8da33f@mail.gmail.com>
	<946fd404102f8bbe15f0665feeddf79f@symetrie.com>
	<8d64b97d0611080659y665f24c7h74962c1845a24e74@mail.gmail.com>
	<8d64b97d0611081127m6c409ee5w42e17a0732a61c07@mail.gmail.com>
Message-ID: <8d64b97d0611081407k101d4fb3r609df313320646c3@mail.gmail.com>

Hi Tim and Jean-Christophe,

The new test setup appears to be working, but there are two things in
better_nested_set that break some of the tests.

Let me know when I have access to the repository-- I want to commit
these changes and get feedback from you guys before mucking around
with other things.

k

On 11/8/06, Krishna Dole <dontfall at gmail.com> wrote:
> hang on... my mistake. i needed to mix the module into active record
> in my abstract_unit.rb, since init.rb wasn't getting loaded in
> testing.
>
> k
>
> On 11/8/06, Krishna Dole <dontfall at gmail.com> wrote:
> > Hi Jean-Christophe,
> >
> > I've implemented the new test setup, but it looks like
> > better_nested_set isn't overriding the built-in nested set in rails
> > core. In other words the tests are all passing, but they aren't using
> > our nested set code.
> >
> > Any ideas?
> >
> > k
> >
> > On 11/7/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> > > Hi Krishna,
> > >
> > >
> > > > OK, let me know if I have this right:
> > > > 1) If I want to contribute, I should work from the source  code on
> > > > rubyforge, not trac.
> > > > 2) You are not happy with the current tests, and would instead like
> > > > them to follow the model of acts_as_modified.
> > > >
> > > > Do you want me to start changing the tests, or is Tim Olsen still in
> > > > charge of that? I don't want to disrupt someone else's work.
> > >
> > > Good idea, since Tim agrees.
> > > Feel free to start from either code you prefer, the plugin code is the
> > > same, I think only tests and vendor/ are added into rubyforge.
> > > Add  yourself to rubyforge, send your id and I'll add it to the admin
> > > so you'll be able to commit.
> > > Or if you're not familiar with svn, send patches here and we'll commit.
> > >
> > > Jean-Christophe Michel
> > > --
> > > symetrie.com
> > >
> > > Better Nested Set for rails:
> > > http://opensource.symetrie.com/trac/better_nested_set
> > >
> > > _______________________________________________
> > > Betternestedset-talk mailing list
> > > Betternestedset-talk at rubyforge.org
> > > http://rubyforge.org/mailman/listinfo/betternestedset-talk
> > >
> >
>

From jc.michel at symetrie.com  Wed Nov  8 17:10:50 2006
From: jc.michel at symetrie.com (Jean-Christophe Michel)
Date: Wed, 8 Nov 2006 23:10:50 +0100
Subject: [Betternestedset-talk] branch to support edge ?
Message-ID: <7d4879ddf02d89a2ca0b9d0234580d96@symetrie.com>

Hi,

What do you think of creating a branch for edge ?
Ticket #20
http://opensource.symetrie.com/trac/better_nested_set/ticket/20
shows an api change that we won't correct for edge without breaking 
code for 1.1.6.


Jean-Christophe Michel


From dontfall at gmail.com  Wed Nov  8 17:36:18 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Wed, 8 Nov 2006 17:36:18 -0500
Subject: [Betternestedset-talk] branch to support edge ?
In-Reply-To: <7d4879ddf02d89a2ca0b9d0234580d96@symetrie.com>
References: <7d4879ddf02d89a2ca0b9d0234580d96@symetrie.com>
Message-ID: <8d64b97d0611081436n38963503kd5727851f2ecd3c8@mail.gmail.com>

The change shown in the patch seems to work for me on 1.1.6-- am I confused?

Krishna

On 11/8/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> Hi,
>
> What do you think of creating a branch for edge ?
> Ticket #20
> http://opensource.symetrie.com/trac/better_nested_set/ticket/20
> shows an api change that we won't correct for edge without breaking
> code for 1.1.6.
>
>
> Jean-Christophe Michel
>
> _______________________________________________
> Betternestedset-talk mailing list
> Betternestedset-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/betternestedset-talk
>

From jc.michel at symetrie.com  Wed Nov  8 17:44:34 2006
From: jc.michel at symetrie.com (Jean-Christophe Michel)
Date: Wed, 8 Nov 2006 23:44:34 +0100
Subject: [Betternestedset-talk] list behaviour change
Message-ID: <873c0f59a5c8da87a19f23b403211c9a@symetrie.com>

I just changed list behaviour so replying always sends to list.
Mailman doesn't recommends this setting, reasons are obscure for me.
let me know if you think I'm wrong.

Jean-Christophe Michel
--
symetrie.com

Better Nested Set for rails:
http://opensource.symetrie.com/trac/better_nested_set


From jc.michel at symetrie.com  Wed Nov  8 17:50:38 2006
From: jc.michel at symetrie.com (Jean-Christophe Michel)
Date: Wed, 8 Nov 2006 23:50:38 +0100
Subject: [Betternestedset-talk] branch to support edge ?
In-Reply-To: <8d64b97d0611081436n38963503kd5727851f2ecd3c8@mail.gmail.com>
References: <7d4879ddf02d89a2ca0b9d0234580d96@symetrie.com>
	<8d64b97d0611081436n38963503kd5727851f2ecd3c8@mail.gmail.com>
Message-ID: <4694f41deba6a73de77e4d6c08aa87ad@symetrie.com>

Hi Krishna,

Le 8 nov. 06, ? 23:36, Krishna Dole a ?crit :
> The change shown in the patch seems to work for me on 1.1.6-- am I 
> confused?

Probably I should have tested instead of imaginating :-)


Jean-Christophe Michel
--
symetrie.com

Better Nested Set for rails:
http://opensource.symetrie.com/trac/better_nested_set


From dontfall at gmail.com  Wed Nov  8 23:35:29 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Wed, 8 Nov 2006 23:35:29 -0500
Subject: [Betternestedset-talk] New test setup
Message-ID: <8d64b97d0611082035s4cc27b33x581dd827641c2d23@mail.gmail.com>

Thanks for adding me. I've just committed the new testing setup; let
me know what you think.

Some tests fail, but I think there are just two issues: the
direct_children method has been renamed, and there are problems with
string scope. Do you favor aliasing the direct_children method, or
cutting ties with the past and changing the tests instead? I'll wait
to hear what you think of the string scope, Jean-Christophe, since I
couldn't tell what was going on.

Other stuff:
- I added instructions in RUNNING_UNIT_TESTS, let me know if you think
this should go in trunk/README instead
- Tests are currently identical to those in rails core.
- Tests presently don't cover the helper

This is my first time working on a plugin, so I'm sure I've done some
things illogically-- don't hesitate to comment or correct.

If it is OK with you, my next plan is to add more tests and fixtures.

k

From dontfall at gmail.com  Wed Nov  8 23:55:34 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Wed, 8 Nov 2006 23:55:34 -0500
Subject: [Betternestedset-talk] New test setup
In-Reply-To: <8d64b97d0611082035s4cc27b33x581dd827641c2d23@mail.gmail.com>
References: <8d64b97d0611082035s4cc27b33x581dd827641c2d23@mail.gmail.com>
Message-ID: <8d64b97d0611082055w48e4a2buecbca54dbffbfec3@mail.gmail.com>

Just browsed through the list archives (which I should have done
earlier) and saw that you already knew about the problem with string
scope.

I also deleted the vendor directory, since I gathered that was only
used by the old tests.

k

On 11/8/06, Krishna Dole <dontfall at gmail.com> wrote:
> Thanks for adding me. I've just committed the new testing setup; let
> me know what you think.
>
> Some tests fail, but I think there are just two issues: the
> direct_children method has been renamed, and there are problems with
> string scope. Do you favor aliasing the direct_children method, or
> cutting ties with the past and changing the tests instead? I'll wait
> to hear what you think of the string scope, Jean-Christophe, since I
> couldn't tell what was going on.
>
> Other stuff:
> - I added instructions in RUNNING_UNIT_TESTS, let me know if you think
> this should go in trunk/README instead
> - Tests are currently identical to those in rails core.
> - Tests presently don't cover the helper
>
> This is my first time working on a plugin, so I'm sure I've done some
> things illogically-- don't hesitate to comment or correct.
>
> If it is OK with you, my next plan is to add more tests and fixtures.
>
> k
>

From dontfall at gmail.com  Thu Nov  9 13:33:02 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Thu, 9 Nov 2006 13:33:02 -0500
Subject: [Betternestedset-talk] Scope
Message-ID: <8d64b97d0611091033j4cb8045bl31a0496260482b0b@mail.gmail.com>

I started  looking at the scope problems. I made some changes that got
all the tests to pass, and then came across Yaroslav's patch:
http://opensource.symetrie.com/trac/better_nested_set/attachment/ticket/7/scoping.diff.
The changes Yaroslav and I made are almost identical!  I also added
aliases for two methods that have been renamed.

What are your thoughts on committing these changes?  I'm not sure if I
have introduced problems for how the scope will be
inherited/overridden in descendant classes, but it sounds like scoping
was broken anyway.

On a related topic, what is your perspective on backwards
compatibility? Should we try to play nice with the old nested set for
the time being?

Krishna
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scope.diff
Type: application/octet-stream
Size: 15705 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/betternestedset-talk/attachments/20061109/781f5c65/attachment-0001.obj 

From jc.michel at symetrie.com  Thu Nov  9 17:11:08 2006
From: jc.michel at symetrie.com (Jean-Christophe Michel)
Date: Thu, 9 Nov 2006 23:11:08 +0100
Subject: [Betternestedset-talk] Scope
In-Reply-To: <8d64b97d0611091033j4cb8045bl31a0496260482b0b@mail.gmail.com>
References: <8d64b97d0611091033j4cb8045bl31a0496260482b0b@mail.gmail.com>
Message-ID: <981274b40535833104b8fe57c3e08070@symetrie.com>

Hi,

Le 9 nov. 06, ? 19:33, Krishna Dole a ?crit :
> What are your thoughts on committing these changes?  I'm not sure if I
> have introduced problems for how the scope will be
> inherited/overridden in descendant classes, but it sounds like scoping
> was broken anyway.

Sure. First of all, thks for all the work you put in there.
If scope is better fixed, commit.
I was wondering wether the patch Yaroslav proposed would break the 
class root method (I mean, being able to call
MyClass.root instead of Myclass.new.root to get the root) where scope 
is a symbol for a class method.
Maybe some tests would help show this behaviour.

> On a related topic, what is your perspective on backwards
> compatibility? Should we try to play nice with the old nested set for
> the time being?

DHH clearly stated on rails core list that things like acts_as should 
one day or another become plugins.
So we won't keep the compatibility for long.
My wish would be to be able to label a 0.1 version with tests, 
preserving all old methods, then for subsequent version we should be 
free. For instance I want to drop add_child asap.

Jean-Christophe Michel
--
symetrie.com

Better Nested Set for rails:
http://opensource.symetrie.com/trac/better_nested_set


From dontfall at gmail.com  Thu Nov  9 19:02:49 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Thu, 9 Nov 2006 19:02:49 -0500
Subject: [Betternestedset-talk] Scope
In-Reply-To: <8d64b97d0611091033j4cb8045bl31a0496260482b0b@mail.gmail.com>
References: <8d64b97d0611091033j4cb8045bl31a0496260482b0b@mail.gmail.com>
Message-ID: <8d64b97d0611091602t463469ecmde877aef02e839c4@mail.gmail.com>

Hi,

> I was wondering wether the patch Yaroslav proposed would break the
> class root method (I mean, being able to call
> MyClass.root instead of Myclass.new.root to get the root) where scope
> is a symbol for a class method.
> Maybe some tests would help show this behaviour.

Ah, good point. But I think that it actually doesn't make sense to use
a scope for class methods anyway. If you had three trees, and used
:tree_id as your scope, calling MyClass.root wouldn't make sense-- you
haven't specified which tree_id you want to be the scope. Thoughts?

k

From dontfall at gmail.com  Fri Nov 10 17:16:02 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Fri, 10 Nov 2006 17:16:02 -0500
Subject: [Betternestedset-talk] Roots
Message-ID: <8d64b97d0611101416r16d531d1xf6112d574853e9e4@mail.gmail.com>

Hi,

Well, talking about scope and the problems I caused for root methods
got me thinking about roots.

There are currently inconsistencies with roots
(http://opensource.symetrie.com/trac/better_nested_set/ticket/15).

I propose that a root is anything where parent_id IS NULL OR parent_id
= 0. Many people (including myself) would never let parent_id = 0, but
not everyone follows that convention, and adding the extra condition
shouldn't hurt anything.

Therefore, I think that we should get rid of the lft and rgt
conditions in the root? method-- but I guess we should wait to change
this. Also, I think that the child method should simply be def
child?() !root? end.

k

From dontfall at gmail.com  Sat Nov 11 18:44:29 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Sat, 11 Nov 2006 18:44:29 -0500
Subject: [Betternestedset-talk] Scope
In-Reply-To: <981274b40535833104b8fe57c3e08070@symetrie.com>
References: <8d64b97d0611091033j4cb8045bl31a0496260482b0b@mail.gmail.com>
	<981274b40535833104b8fe57c3e08070@symetrie.com>
Message-ID: <8d64b97d0611111544n716aa9fbi3062666cc1b19f9@mail.gmail.com>

Hi,

I went ahead and committed the scope changes and aliases I had
mentioned before. I hope this is OK-- feel free to revert this if you
don't agree with it.

I've also just committed fairly comprehensive tests for all methods
except the move_to* methods (which need tests the most... ;). All
tests now pass (over 200 assertions!).

My plan now is to add methods for checking the consistency of trees
(I've written these for my own projects and just need to port them).
After that I will complete the tests for the move_to methods, which
will be a lot easier with the error checking methods in place.

Hope you're having a great weekend,

Krishna


On 11/9/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> Hi,
>
> Le 9 nov. 06, ? 19:33, Krishna Dole a ?crit :
> > What are your thoughts on committing these changes?  I'm not sure if I
> > have introduced problems for how the scope will be
> > inherited/overridden in descendant classes, but it sounds like scoping
> > was broken anyway.
>
> Sure. First of all, thks for all the work you put in there.
> If scope is better fixed, commit.
> I was wondering wether the patch Yaroslav proposed would break the
> class root method (I mean, being able to call
> MyClass.root instead of Myclass.new.root to get the root) where scope
> is a symbol for a class method.
> Maybe some tests would help show this behaviour.
>
> > On a related topic, what is your perspective on backwards
> > compatibility? Should we try to play nice with the old nested set for
> > the time being?
>
> DHH clearly stated on rails core list that things like acts_as should
> one day or another become plugins.
> So we won't keep the compatibility for long.
> My wish would be to be able to label a 0.1 version with tests,
> preserving all old methods, then for subsequent version we should be
> free. For instance I want to drop add_child asap.
>
> Jean-Christophe Michel
> --
> symetrie.com
>
> Better Nested Set for rails:
> http://opensource.symetrie.com/trac/better_nested_set
>
> _______________________________________________
> Betternestedset-talk mailing list
> Betternestedset-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/betternestedset-talk
>

From jc.michel at symetrie.com  Sun Nov 12 16:38:39 2006
From: jc.michel at symetrie.com (Jean-Christophe Michel)
Date: Sun, 12 Nov 2006 22:38:39 +0100
Subject: [Betternestedset-talk] Roots
In-Reply-To: <8d64b97d0611101416r16d531d1xf6112d574853e9e4@mail.gmail.com>
References: <8d64b97d0611101416r16d531d1xf6112d574853e9e4@mail.gmail.com>
Message-ID: <41be4d2f478b5b128eac2575bb5f1f2f@symetrie.com>

Hi Krishna,

Le 10 nov. 06, ? 23:16, Krishna Dole a ?crit :
> Well, talking about scope and the problems I caused for root methods
> got me thinking about roots.
>
> There are currently inconsistencies with roots
> (http://opensource.symetrie.com/trac/better_nested_set/ticket/15)

Just replied on the ticket:
root? is kept only for compatibility with existent code; we'll remove 
it after 0.1 version (the one with tests and a working scope) is out. 
Maybe we should correct root? to return correct info.

> I propose that a root is anything where parent_id IS NULL OR parent_id
> = 0. Many people (including myself) would never let parent_id = 0, but
> not everyone follows that convention, and adding the extra condition
> shouldn't hurt anything.

Honnestly I'd prefer that root means parent=NULL.
But if it can fix root? to be consistent with root method, why not...

> Therefore, I think that we should get rid of the lft and rgt
> conditions in the root? method-- but I guess we should wait to change
> this. Also, I think that the child method should simply be def
> child?() !root? end.

I think we should get rid of root? and child? method after 0.1. When 
would such methods have any use ?

Jean-Christophe Michel
--
symetrie.com

Better Nested Set for rails:
http://opensource.symetrie.com/trac/better_nested_set


From jc.michel at symetrie.com  Sun Nov 12 17:49:05 2006
From: jc.michel at symetrie.com (Jean-Christophe Michel)
Date: Sun, 12 Nov 2006 23:49:05 +0100
Subject: [Betternestedset-talk] Scope
In-Reply-To: <8d64b97d0611111544n716aa9fbi3062666cc1b19f9@mail.gmail.com>
References: <8d64b97d0611091033j4cb8045bl31a0496260482b0b@mail.gmail.com>
	<981274b40535833104b8fe57c3e08070@symetrie.com>
	<8d64b97d0611111544n716aa9fbi3062666cc1b19f9@mail.gmail.com>
Message-ID: <d3bec1764b79bcdd056797a2c845f58b@symetrie.com>

Hi,


Le 12 nov. 06, ? 00:44, Krishna Dole a ?crit :
> I went ahead and committed the scope changes and aliases I had
> mentioned before. I hope this is OK-- feel free to revert this if you
> don't agree with it.
>
> I've also just committed fairly comprehensive tests for all methods
> except the move_to* methods (which need tests the most... ;). All
> tests now pass (over 200 assertions!).

Very good job. One doesn't pass here (postgresql):
   1) Failure:
test_root(MixinNestedSetTest) [./test/acts_as_nested_set_test.rb:175]:
<#<NestedSet:0x15dc054
  @attributes=
   {"updated_at"=>nil,
    "type"=>"NestedSet",
    "lft"=>nil,
    "id"=>"3001",
    "root_id"=>nil,
    "rgt"=>nil,
    "pos"=>nil,
    "parent_id"=>nil,
    "created_at"=>nil}>> expected but was
<#<NestedSet:0x15da31c
  @attributes=
   {"updated_at"=>nil,
    "type"=>"NestedSet",
    "lft"=>nil,
    "id"=>"3003",
    "root_id"=>nil,
    "rgt"=>nil,
    "pos"=>nil,
    "parent_id"=>nil,
    "created_at"=>nil}>>.

29 tests, 209 assertions, 1 failures, 0 errors


Another point: shouldn't we rewrite add_child with current node 
creation methods ?
(even if we drop this method > 0.1)

> My plan now is to add methods for checking the consistency of trees
> (I've written these for my own projects and just need to port them).
> After that I will complete the tests for the move_to methods, which
> will be a lot easier with the error checking methods in place.

Good idea, that's exactly what I intended to do.

> Hope you're having a great weekend,

Fine, just coming back from a concert we gave this aftenoon ;-)

Jean-Christophe Michel
--
symetrie.com

Better Nested Set for rails:
http://opensource.symetrie.com/trac/better_nested_set


From dontfall at gmail.com  Mon Nov 13 10:35:48 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Mon, 13 Nov 2006 10:35:48 -0500
Subject: [Betternestedset-talk] Roots
In-Reply-To: <41be4d2f478b5b128eac2575bb5f1f2f@symetrie.com>
References: <8d64b97d0611101416r16d531d1xf6112d574853e9e4@mail.gmail.com>
	<41be4d2f478b5b128eac2575bb5f1f2f@symetrie.com>
Message-ID: <8d64b97d0611130735s7302e7f0h916827c28952ab1c@mail.gmail.com>

Hi Jean-Christophe,

> Honnestly I'd prefer that root means parent=NULL.

OK, let's allow parent=0 in the 0.1 release for compatibility, and
drop it after that. We can put a warning in the documentation that
parent should never be 0.

> I think we should get rid of root? and child? method after 0.1.

Agreed.

k

From dontfall at gmail.com  Mon Nov 13 10:57:24 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Mon, 13 Nov 2006 10:57:24 -0500
Subject: [Betternestedset-talk] Scope
In-Reply-To: <d3bec1764b79bcdd056797a2c845f58b@symetrie.com>
References: <8d64b97d0611091033j4cb8045bl31a0496260482b0b@mail.gmail.com>
	<981274b40535833104b8fe57c3e08070@symetrie.com>
	<8d64b97d0611111544n716aa9fbi3062666cc1b19f9@mail.gmail.com>
	<d3bec1764b79bcdd056797a2c845f58b@symetrie.com>
Message-ID: <8d64b97d0611130757x1fa6006flfa1e6c78c3b22656@mail.gmail.com>

Hi Jean-Christophe,

> Very good job. One doesn't pass here (postgresql):

Ah, I'm glad you are testing on Postgres. I think we should try to run
the tests on MySQL, Postgres and SQLite, since those seem to be the
most popular. I suppose running on all 3 adapters should be the
default rake task. Do you use SQLite? I looked at setting it up, but
couldn't figure out if sqlite or sqlite3 was the version/gem to use.

> Another point: shouldn't we rewrite add_child with current node
> creation methods ?

Agreed-- I'm planning to do that.

Since one of the tests failed on postgres, I guess at this point my plan is:
1) get all 3 databases installed and get the tests to run
2) add and test the error-checking methods
3) rewrite add_child and test the move_to methods

> Fine, just coming back from a concert we gave this aftenoon ;-)

Ah! What sort of music do you perform?

Krishna

From dontfall at gmail.com  Tue Nov 14 10:22:06 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Tue, 14 Nov 2006 10:22:06 -0500
Subject: [Betternestedset-talk] Tests for SQLite3 and PostgreSQL
Message-ID: <8d64b97d0611140722i4791f09fta3a97f707246b96e@mail.gmail.com>

Hi Jean-Christophe,

I've just committed changes that add support for testing on SQLite3
and PostgreSQL. The default rake task runs the tests on all adapters.
All tests pass for me on all three databases (the error you
encountered turned out to be a flawed test, which I fixed).

I'm not terribly happy with how I set up the files and tasks to do
this. I was hoping to have a single test file, and call it from rake
with different arguments. Instead I ended up creating a file for each
database. Please let me know if you see a better way of doing this.

Being a choir conductor certainly sounds nice-- congratulations on
that! I hadn't heard of Carl Heinrich Graun, though that isn't
surprising. In that time period I haven't strayed too far from Bach
and Vivaldi.

Krishna

From dontfall at gmail.com  Tue Nov 14 21:55:13 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Tue, 14 Nov 2006 21:55:13 -0500
Subject: [Betternestedset-talk] Tests, tickets
Message-ID: <8d64b97d0611141855l62aa6bb5n7f8cca4f2e17243e@mail.gmail.com>

Hi Jean-Christophe,

I've rewritten add_child, and I'm pretty close to getting tests for
the move_to methods set up.

There are a number of tickets currently assigned to you that I think I
can fix (7,17, 19 and 9)-- do you mind if I take these?

Cheers,
Krishna

From jc.michel at symetrie.com  Wed Nov 15 03:29:31 2006
From: jc.michel at symetrie.com (Jean-Christophe Michel)
Date: Wed, 15 Nov 2006 09:29:31 +0100
Subject: [Betternestedset-talk] Tests, tickets
In-Reply-To: <8d64b97d0611141855l62aa6bb5n7f8cca4f2e17243e@mail.gmail.com>
References: <8d64b97d0611141855l62aa6bb5n7f8cca4f2e17243e@mail.gmail.com>
Message-ID: <cd2998eb8505de5a18c1b0092d642df9@symetrie.com>

HI,

Le 15 nov. 06, ? 03:55, Krishna Dole a ?crit :
> I've rewritten add_child, and I'm pretty close to getting tests for
> the move_to methods set up.
>
> There are a number of tickets currently assigned to you that I think I
> can fix (7,17, 19 and 9)-- do you mind if I take these?

Certainly not!
Take them and fix them.
Thanks to your help we'll be able to release 0.1 soon !


Jean-Christophe Michel
--
symetrie.com

Better Nested Set for rails:
http://opensource.symetrie.com/trac/better_nested_set


From dontfall at gmail.com  Thu Nov 16 16:20:44 2006
From: dontfall at gmail.com (Krishna Dole)
Date: Thu, 16 Nov 2006 16:20:44 -0500
Subject: [Betternestedset-talk] Tests, tickets
In-Reply-To: <cd2998eb8505de5a18c1b0092d642df9@symetrie.com>
References: <8d64b97d0611141855l62aa6bb5n7f8cca4f2e17243e@mail.gmail.com>
	<cd2998eb8505de5a18c1b0092d642df9@symetrie.com>
Message-ID: <8d64b97d0611161320v15c444d9la80b5793477790dc@mail.gmail.com>

Hi Jean-Christophe,

I submitted a bunch of stuff yesterday. I think the basic test suite
is complete. I'm sure we will add tests as bugs are submitted and
features are added, but we currently have pretty good coverage. There
are tests for every method (over 300 assertions), and we recently
passed an important milestone: our code-to-test ratio passed 1:1.

I've submitted fixes for the tickets mentioned below, so now we only
have 4 active tickets.

I rewrote the add_child method to use move_to, but it turned out to be
pretty ugly. The old code allowed nil left and right values, so I had
to write a bunch of stuff to deal with those. Ah well, we will be rid
of it soon.

I'll take a look at the documentation in the near future and see if I
can improve it at all.

Krishna

On 11/15/06, Jean-Christophe Michel <jc.michel at symetrie.com> wrote:
> HI,
>
> Le 15 nov. 06, ? 03:55, Krishna Dole a ?crit :
> > I've rewritten add_child, and I'm pretty close to getting tests for
> > the move_to methods set up.
> >
> > There are a number of tickets currently assigned to you that I think I
> > can fix (7,17, 19 and 9)-- do you mind if I take these?
>
> Certainly not!
> Take them and fix them.
> Thanks to your help we'll be able to release 0.1 soon !
>
>
> Jean-Christophe Michel
> --
> symetrie.com
>
> Better Nested Set for rails:
> http://opensource.symetrie.com/trac/better_nested_set
>
> _______________________________________________
> Betternestedset-talk mailing list
> Betternestedset-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/betternestedset-talk
>