<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[757] trunk/alexandria/lib/alexandria/library.rb: Fixed bug [#14592] Fails to start: undefined method `isbn'</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd>757</dd>
<dt>Author</dt> <dd>cathalmagus</dd>
<dt>Date</dt> <dd>2007-10-09 20:27:28 -0400 (Tue, 09 Oct 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fixed bug [#14592] Fails to start: undefined method `isbn'
This caused a crash if a book file (*.yaml) was empty.
Now, it logs a warning and proceeds.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkalexandrialibalexandrialibraryrb">trunk/alexandria/lib/alexandria/library.rb</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkalexandrialibalexandrialibraryrb"></a>
<div class="modfile"><h4>Modified: trunk/alexandria/lib/alexandria/library.rb (756 => 757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/alexandria/lib/alexandria/library.rb        2007-10-09 23:36:13 UTC (rev 756)
+++ trunk/alexandria/lib/alexandria/library.rb        2007-10-10 00:27:28 UTC (rev 757)
</span><span class="lines">@@ -32,6 +32,8 @@
</span><span class="cx">
</span><span class="cx"> module Alexandria
</span><span class="cx"> class Library < Array
</span><ins>+ include Logging
+
</ins><span class="cx"> attr_reader :name
</span><span class="cx"> attr_accessor :ruined_books
</span><span class="cx"> DIR = File.join(ENV['HOME'], '.alexandria')
</span><span class="lines">@@ -76,6 +78,10 @@
</span><span class="cx">
</span><span class="cx"> #puts "back from the future of #{test[1]}:" if test[0] == 1
</span><span class="cx"> #puts "Regularizing book :#{test[1]}" if $DEBUG
</span><ins>+ if not File.size? test[1]
+ log.warn { "Book file #{test[1]} was empty"}
+ next
+ end
</ins><span class="cx"> book = self.regularize_book_from_yaml(test[1])
</span><span class="cx"> #puts "File state for #{test[1].inspect}: " + book.to_yaml if test[0] == 1
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>