<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[639] trunk/alexandria: z3950.rb : now returns [Book.new(...)] instead of [Book.new(...), nil] (where nil is the image).</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd>639</dd>
<dt>Author</dt> <dd>laurusnobilis</dd>
<dt>Date</dt> <dd>2007-03-03 10:10:13 -0500 (Sat, 03 Mar 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>z3950.rb : now returns [Book.new(...)] instead of [Book.new(...), nil] (where nil is the image). This is required to pass the test.
test_providers.rb: added test of LOC and BL, and grouped together tests of providers depending on optional libraries</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkalexandrialibalexandriabook_providersz3950rb">trunk/alexandria/lib/alexandria/book_providers/z3950.rb</a></li>
<li><a href="#trunkalexandriateststest_providersrb">trunk/alexandria/tests/test_providers.rb</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkalexandrialibalexandriabook_providersz3950rb"></a>
<div class="modfile"><h4>Modified: trunk/alexandria/lib/alexandria/book_providers/z3950.rb (638 => 639)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/alexandria/lib/alexandria/book_providers/z3950.rb 2007-03-03 14:43:31 UTC (rev 638)
+++ trunk/alexandria/lib/alexandria/book_providers/z3950.rb 2007-03-03 15:10:13 UTC (rev 639)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> marc.respond_to?(:publish_year) \
</span><span class="cx"> ? marc.publish_year : nil,
</span><span class="cx"> (marc.edition or ""))
</span><del>- results << [book, nil]
</del><ins>+ results << [book]
</ins><span class="cx"> end
</span><span class="cx"> type == SEARCH_BY_ISBN ? results.first : results
</span><span class="cx"> end
</span><span class="lines">@@ -160,7 +160,7 @@
</span><span class="cx"> sutrs_text = record.render
</span><span class="cx"> book = book_from_sutrs(sutrs_text)
</span><span class="cx"> if book
</span><del>- results << [book, nil]
</del><ins>+ results << [book]
</ins><span class="cx"> end
</span><span class="cx"> end
</span><span class="cx"> type == SEARCH_BY_ISBN ? results.first : results
</span></span></pre></div>
<a id="trunkalexandriateststest_providersrb"></a>
<div class="modfile"><h4>Modified: trunk/alexandria/tests/test_providers.rb (638 => 639)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/alexandria/tests/test_providers.rb 2007-03-03 14:43:31 UTC (rev 638)
+++ trunk/alexandria/tests/test_providers.rb 2007-03-03 15:10:13 UTC (rev 639)
</span><span class="lines">@@ -29,6 +29,8 @@
</span><span class="cx"> end
</span><span class="cx"> end
</span><span class="cx">
</span><ins>+ # providers depending on optional libraries
+
</ins><span class="cx"> def test_amazon_isbn
</span><span class="cx"> __test_provider(Alexandria::BookProviders::AmazonProvider,
</span><span class="cx"> '9780385504201')
</span><span class="lines">@@ -49,6 +51,25 @@
</span><span class="cx"> 'Confederacy Dunces', Alexandria::BookProviders::SEARCH_BY_KEYWORD)
</span><span class="cx"> end
</span><span class="cx">
</span><ins>+ def test_dea
+ __test_provider(Alexandria::BookProviders::DeaStore_itProvider,
+ '9788817012980')
+ __test_provider(Alexandria::BookProviders::DeaStore_itProvider,
+ '9788806134747')
+ end
+
+ def test_LOC
+ __test_provider(Alexandria::BookProviders::LOCProvider,
+ '9780805335583')
+ end
+
+ def test_BL
+ __test_provider(Alexandria::BookProviders::BLProvider,
+ '9781853260803')
+ end
+
+ # providers supposed to be always working
+
</ins><span class="cx"> def test_bn
</span><span class="cx"> __test_provider(Alexandria::BookProviders::BNProvider,
</span><span class="cx"> '9780961328917') # see #1433
</span><span class="lines">@@ -94,13 +115,6 @@
</span><span class="cx"> '9788599170380')
</span><span class="cx"> end
</span><span class="cx">
</span><del>- def test_dea
- __test_provider(Alexandria::BookProviders::DeaStore_itProvider,
- '9788817012980')
- __test_provider(Alexandria::BookProviders::DeaStore_itProvider,
- '9788806134747')
- end
-
</del><span class="cx"> def test_bol
</span><span class="cx"> __test_provider(Alexandria::BookProviders::BOL_itProvider,
</span><span class="cx"> '9788817012980')
</span></span></pre>
</div>
</div>
</body>
</html>