 |
Forums |
Admin Start New Thread
By: Rocky Bernstein
RE: columnize for Ruby 1.9 (was ruby-debug...) [ reply ] 2009-08-02 10:22
|
I've looked over the linecache changes on github and I have sent you more a more detailed email.
Basically I don't think we want to follow the approach for Ruby 1.9 of compiling the code followed by running a disassembly and a parse of the string output. And doing all of this in a C extension.
So please don't check that in. However I do notice there are a number of other small improvements and corrections of typographical errors in the github repository. Those changes can and should be checked into the 1.8 trunk code.
Thanks.
|
By: Rocky Bernstein
columnize for Ruby 1.9 (was ruby-debug...) [ reply ] 2009-07-26 06:20
|
Do you mind if I put the changes to columnize for 1.9 back into trunk?
Or better, I can give you commit access there and you can make commit the changes there directly. But if you decide to go this route there are a couple of small changes I'd suggest. First replace the tabs with the corresponding number of space characters. Second, don't change the version number from 0.3.1 (the next upcoming release) to 0.3.3.
Thanks.
|
By: Mark Moseley
RE: ruby-debug for Ruby 1.9 [ reply ] 2009-07-22 15:14
|
I'm not sure I follow. I tried to import the entire ruby-debug SVN tree from here, but that failed twice with some kind of connection error. It worked for columnize and linecache, though.
So I pulled the tip of the trunk and started with that at github. Then I checked in my changes on top of that.
Can you clarify?
|
By: Mark Moseley
RE: ruby-debug for Ruby 1.9 [ reply ] 2009-07-21 21:27
|
|
OK, I'll do that. At this point I've put the columnize and linecache diffs over on Rocky's miscellaneous gems project. I'll get them to github and then I'll deal with the ruby-debug-base changes.
|
|
 |